Changeset 6641

Timestamp:

08/04/2017 01:08:43 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Scripts: Do not enqueue if not is_bbpress().

This reduces the number of external scripts that are enqueued on non-bbPress pages. Put another way, it makes sure that bbPress styles & scripts are only loaded on pages where bbPress content is known to exist.

Fibes #3138. Props DJPaul.

Location:

trunk/src

Files:

• includes/core/template-functions.php (modified) (4 diffs)
• templates/default/bbpress-functions.php (modified) (1 diff)

trunk/src/includes/core/template-functions.php

@@ -113 +113 @@
  *
  * @since 2.5.0 bbPress (r5180)
+ * @since 2.6.0 bbPress (r6640) Bail early if not a bbPress page/shortcode
  *
  * @param string      $handle Name of the stylesheet.
@@ -128 +129 @@
 function bbp_enqueue_style( $handle = '', $file = '', $deps = array(), $ver = false, $media = 'all' ) {
 
+    // Bail if not on a bbPress page or shortcode
+    if ( ! is_bbpress() ) {
+        return;
+    }
+
     // No file found yet
     $located = false;
@@ -185 +191 @@
  *
  * @since 2.5.0 bbPress (r5180)
+ * @since 2.6.0 bbPress (r6640) Bail early if not a bbPress page/shortcode
  *
  * @param string      $handle    Name of the script.
@@ -199 +206 @@
 function bbp_enqueue_script( $handle = '', $file = '', $deps = array(), $ver = false, $in_footer = false ) {
 
+    // Bail if not on a bbPress page or shortcode
+    if ( ! is_bbpress() ) {
+        return;
+    }
+
     // No file found yet
     $located = false;

trunk/src/templates/default/bbpress-functions.php

@@ -156 +156 @@
         // Editor scripts
         // @see https://bbpress.trac.wordpress.org/ticket/2930
-        if ( bbp_use_wp_editor() && is_bbpress() ) {
+        if ( bbp_use_wp_editor() ) {
             $scripts['bbpress-editor'] = array(
                 'file'         => 'js/editor' . $suffix . '.js',