Changeset 6638

Timestamp:

07/27/2017 12:15:02 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Converter: Introduce update_query() method, to help with updating the last query option.

This abstracts the update_option() approach for future scrutiny.

File:

• trunk/src/includes/admin/classes/class-bbp-converter-base.php (modified) (4 diffs)

trunk/src/includes/admin/classes/class-bbp-converter-base.php

@@ -400 +400 @@
             $fields      = implode( ',', $field_list );
             $forum_query = "SELECT {$fields} FROM {$this->opdb->prefix}{$from_tablename} LIMIT {$start}, {$this->max_rows}";
+
+            // Set this query as the last one ran
+            $this->update_query( $forum_query );
+
+            // Get results as an array
             $forum_array = $this->opdb->get_results( $forum_query, ARRAY_A );
-
-            // Set this query as the last one ran
-            update_option( '_bbp_converter_query', $forum_query );
 
             // Query returned some results
@@ -921 +923 @@
      */
     private function get_row( $query = '' ) {
-        update_option( '_bbp_converter_query', $query );
+        $this->update_query( $query );
 
         return $this->wpdb->get_row( $query );
@@ -933 +935 @@
      */
     private function get_results( $query = '', $output = OBJECT ) {
-        update_option( '_bbp_converter_query', $query );
+        $this->update_query( $query );
 
         return (array) $this->wpdb->get_results( $query, $output );
@@ -944 +946 @@
      */
     private function query( $query = '' ) {
-        update_option( '_bbp_converter_query', $query );
+        $this->update_query( $query );
 
         return $this->wpdb->query( $query );
+    }
+
+    /**
+     * Update the last query ran
+     *
+     * @since 2.6.0 bbPress (r6637)
+     *
+     * @param string $query The literal MySQL query
+     * @return bool
+     */
+    private function update_query( $query = '' ) {
+        return update_option( '_bbp_converter_query', $query );
     }