Changeset 6630 for trunk/src/templates/default/bbpress/form-search.php

Timestamp:

07/19/2017 05:23:30 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Search: move bbp_allow_search() checks into form template parts.

This allows the inclusion of those forms without needing to wrap each inclusion statement in its own feature check, making search a more atomic and isolated feature within bbPress.

It also should conclude the development of the user content search functionality.

Because this involves some template-part changes to the "Default" template pack, users who have opted to override these parts in their own themes will not receive these updates (nor should they.) This is a known consequence of including template parts in themes, so while still not an ideal system, will not result in any breakage for existing sites.

File:

• trunk/src/templates/default/bbpress/form-search.php (modified) (1 diff)

trunk/src/templates/default/bbpress/form-search.php

@@ -11 +11 @@
 defined( 'ABSPATH' ) || exit;
 
-?>
+if ( bbp_allow_search() ) : ?>
 
-<form role="search" method="get" id="bbp-search-form" action="<?php bbp_search_url(); ?>">
-    <div>
-        <label class="screen-reader-text hidden" for="bbp_search"><?php esc_html_e( 'Search for:', 'bbpress' ); ?></label>
-        <input type="hidden" name="action" value="bbp-search-request" />
-        <input type="text" value="<?php bbp_search_terms(); ?>" name="bbp_search" id="bbp_search" />
-        <input class="button" type="submit" id="bbp_search_submit" value="<?php esc_attr_e( 'Search', 'bbpress' ); ?>" />
+    <div class="bbp-search-form">
+        <form role="search" method="get" id="bbp-search-form" action="<?php bbp_search_url(); ?>">
+            <div>
+                <label class="screen-reader-text hidden" for="bbp_search"><?php esc_html_e( 'Search for:', 'bbpress' ); ?></label>
+                <input type="hidden" name="action" value="bbp-search-request" />
+                <input type="text" value="<?php bbp_search_terms(); ?>" name="bbp_search" id="bbp_search" />
+                <input class="button" type="submit" id="bbp_search_submit" value="<?php esc_attr_e( 'Search', 'bbpress' ); ?>" />
+            </div>
+        </form>
     </div>
-</form>
+
+<?php endif;