Changeset 6612

Timestamp:

07/04/2017 03:54:06 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Queries: Use new object_type over old post_type.

When bbp_get_user_object_ids() was introduced, some helpers did not get updated to use the new argument key. This change fixes that, and fixes failing tests in the process.

Note that these tests are testing new & unused helper functions for 2.6, so it's unlikely any noticable problems occurred from these being broken.

Location:

trunk/src/includes

Files:

• search/template.php (modified) (1 diff)
• topics/functions.php (modified) (1 diff)
• users/engagements.php (modified) (3 diffs)
• users/functions.php (modified) (1 diff)

trunk/src/includes/search/template.php

@@ -48 +48 @@
 
         // Default view=all statuses
-        $post_statuses = array(
-            bbp_get_public_status_id(),
-            bbp_get_closed_status_id(),
-            bbp_get_spam_status_id(),
-            bbp_get_trash_status_id(),
-            bbp_get_pending_status_id()
-        );
+        $post_statuses = array_keys( bbp_get_topic_statuses() );
 
         // Add support for private status

trunk/src/includes/topics/functions.php

@@ -1824 +1824 @@
     // Filter & return
     return (array) apply_filters( 'bbp_get_topic_statuses', array(
-        bbp_get_public_status_id()  => _x( 'Open',    'Open the topic',        'bbpress' ),
-        bbp_get_closed_status_id()  => _x( 'Closed',  'Close the topic',       'bbpress' ),
-        bbp_get_spam_status_id()    => _x( 'Spam',    'Spam the topic',        'bbpress' ),
-        bbp_get_trash_status_id()   => _x( 'Trash',   'Trash the topic',       'bbpress' ),
-        bbp_get_pending_status_id() => _x( 'Pending', 'Mark topic as pending', 'bbpress' ),
+        bbp_get_public_status_id()  => _x( 'Open',    'Open the topic',      'bbpress' ),
+        bbp_get_closed_status_id()  => _x( 'Closed',  'Close the topic',     'bbpress' ),
+        bbp_get_spam_status_id()    => _x( 'Spam',    'Spam the topic',      'bbpress' ),
+        bbp_get_trash_status_id()   => _x( 'Trash',   'Trash the topic',     'bbpress' ),
+        bbp_get_pending_status_id() => _x( 'Pending', 'Unapprove the topic', 'bbpress' )
     ), $topic_id );
 }

trunk/src/includes/users/engagements.php

@@ -960 +960 @@
 
     // Parse arguments
-    $r = bbp_parse_args( $r['args'], $defaults, "get_{$r['filter']}_args" );
+    $query_args = bbp_parse_args( $r['args'], $defaults, "get_{$r['filter']}_args" );
 
     // Queries
     if ( 'post' === $r['meta_type'] ) {
-        $query      = new WP_Query( $r );
+        $query      = new WP_Query( $query_args );
         $object_ids = $query->posts;
     }
@@ -983 +983 @@
 function bbp_get_moderator_forum_ids( $user_id = 0 ) {
     return bbp_get_user_object_ids( array(
-        'user_id'   => $user_id,
-        'meta_key'  => '_bbp_moderator_id',
-        'post_type' => bbp_get_forum_post_type(),
-        'filter'    => 'moderator_forum_ids'
+        'user_id'     => $user_id,
+        'meta_key'    => '_bbp_moderator_id',
+        'object_type' => bbp_get_forum_post_type(),
+        'filter'      => 'moderator_forum_ids'
     ) );
 }
@@ -1035 +1035 @@
 function bbp_get_user_subscribed_forum_ids( $user_id = 0 ) {
     return bbp_get_user_object_ids( array(
-        'user_id'   => $user_id,
-        'meta_key'  => '_bbp_subscription',
-        'post_type' => bbp_get_forum_post_type(),
-        'filter'    => 'user_subscribed_forum_ids'
+        'user_id'     => $user_id,
+        'meta_key'    => '_bbp_subscription',
+        'object_type' => bbp_get_forum_post_type(),
+        'filter'      => 'user_subscribed_forum_ids'
     ) );
 }

trunk/src/includes/users/functions.php

@@ -648 +648 @@
     $user_id = bbp_get_user_id( $user_id );
     $bbp_db  = bbp_db();
+    $statii  = "'" . implode( "', '", bbp_get_public_topic_statuses() ) . "'";
     $sql     = "SELECT COUNT(*)
             FROM {$bbp_db->posts}
             WHERE post_author = %d
                 AND post_type = %s
-                AND post_status = %s";
-
-    $query   = $bbp_db->prepare( $sql, $user_id, bbp_get_reply_post_type(), bbp_get_public_status_id() );
+                AND post_status IN ({$statii})";
+
+    $query   = $bbp_db->prepare( $sql, $user_id, bbp_get_reply_post_type() );
     $count   = (int) $bbp_db->get_var( $query );