Changeset 6607 for trunk/src/includes/topics/functions.php

Timestamp:

07/02/2017 04:39:49 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Queries: nopaging audit.

• In r6506 the nopaging query argument was added to various queries to avoid paginating results when it wasn't necessary. This resulted in a few queries (widgets mainly) not obeying their specific settings.
• In #3123, other inconsistencies in our query arguments were uncovered, triggering the need to audit our query usages and equalize them once again.

This change brings all queries back to par with one another, specifically in regards to posts_per_page => -1 style queries, and queries where filters can be suppressed and meta/term caches should not be primed.

It also groups together the get_user_object_ids functions. These are now unused in bbPress proper, though were previously useful before the engagements API was in place. These queries are considered too inefficient to rely upon in large-scale applications, but are included to provide filterable wrappers should someone need them, or should we need to bring them back later.

Props thebrandonallen. Fixes #3123.

File:

• trunk/src/includes/topics/functions.php (modified) (4 diffs)

trunk/src/includes/topics/functions.php

@@ -2882 +2882 @@
     // Topic is being spammed, so its replies are trashed
     $replies = new WP_Query( array(
-        'suppress_filters' => true,
-        'post_type'        => bbp_get_reply_post_type(),
-        'post_status'      => bbp_get_public_status_id(),
-        'post_parent'      => $topic_id,
-        'posts_per_page'   => -1,
-        'nopaging'         => true,
-        'no_found_rows'    => true,
-        'fields'           => 'id=>parent'
+        'fields'         => 'id=>parent',
+        'post_type'      => bbp_get_reply_post_type(),
+        'post_status'    => bbp_get_public_status_id(),
+        'post_parent'    => $topic_id,
+        'posts_per_page' => -1,
+
+        // Performance
+        'nopaging'               => true,
+        'suppress_filters'       => true,
+        'update_post_term_cache' => false,
+        'update_post_meta_cache' => false,
+        'ignore_sticky_posts'    => true,
+        'no_found_rows'          => true
     ) );
 
@@ -2915 +2920 @@
 /**
  * Store the tags to a topic in post meta before it's marked as spam so they
- * can be retreived and unspammed later.
+ * can be retrieved and unspammed later.
  *
  * Usually you'll want to do this before the topic itself is marked as spam.
@@ -3273 +3278 @@
     // Note that we get all post statuses here
     $replies = new WP_Query( array(
-        'suppress_filters' => true,
-        'post_type'        => bbp_get_reply_post_type(),
-        'post_status'      => array_keys( get_post_stati() ),
-        'post_parent'      => $topic_id,
-        'posts_per_page'   => -1,
-        'nopaging'         => true,
-        'no_found_rows'    => true,
-        'fields'           => 'id=>parent'
+        'fields'         => 'id=>parent',
+        'post_type'      => bbp_get_reply_post_type(),
+        'post_status'    => array_keys( get_post_stati() ),
+        'post_parent'    => $topic_id,
+        'posts_per_page' => -1,
+
+        // Performance
+        'nopaging'               => true,
+        'suppress_filters'       => true,
+        'update_post_term_cache' => false,
+        'update_post_meta_cache' => false,
+        'ignore_sticky_posts'    => true,
+        'no_found_rows'          => true
     ) );
 
@@ -3329 +3339 @@
     // Topic is being trashed, so its replies are trashed too
     $replies = new WP_Query( array(
-        'suppress_filters' => true,
-        'post_type'        => bbp_get_reply_post_type(),
-        'post_status'      => bbp_get_public_status_id(),
-        'post_parent'      => $topic_id,
-        'posts_per_page'   => -1,
-        'nopaging'         => true,
-        'no_found_rows'    => true,
-        'fields'           => 'id=>parent'
+        'fields'         => 'id=>parent',
+        'post_type'      => bbp_get_reply_post_type(),
+        'post_status'    => bbp_get_public_status_id(),
+        'post_parent'    => $topic_id,
+        'posts_per_page' => -1,
+
+        // Performance
+        'nopaging'               => true,
+        'suppress_filters'       => true,
+        'update_post_term_cache' => false,
+        'update_post_meta_cache' => false,
+        'ignore_sticky_posts'    => true,
+        'no_found_rows'          => true
     ) );