Changeset 6607 for trunk/src/includes/common/functions.php

Timestamp:

07/02/2017 04:39:49 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Queries: nopaging audit.

• In r6506 the nopaging query argument was added to various queries to avoid paginating results when it wasn't necessary. This resulted in a few queries (widgets mainly) not obeying their specific settings.
• In #3123, other inconsistencies in our query arguments were uncovered, triggering the need to audit our query usages and equalize them once again.

This change brings all queries back to par with one another, specifically in regards to posts_per_page => -1 style queries, and queries where filters can be suppressed and meta/term caches should not be primed.

It also groups together the get_user_object_ids functions. These are now unused in bbPress proper, though were previously useful before the engagements API was in place. These queries are considered too inefficient to rely upon in large-scale applications, but are included to provide filterable wrappers should someone need them, or should we need to bring them back later.

Props thebrandonallen. Fixes #3123.

File:

• trunk/src/includes/common/functions.php (modified) (4 diffs)

trunk/src/includes/common/functions.php

@@ -1472 +1472 @@
 
     $query = new WP_Query( array(
-        'fields'      => 'ids',
-        'post_parent' => $parent_id,
-        'post_status' => $post_status,
-        'post_type'   => $post_type,
-        'orderby'     => array(
+        'fields'         => 'ids',
+        'post_parent'    => $parent_id,
+        'post_status'    => $post_status,
+        'post_type'      => $post_type,
+        'posts_per_page' => 1,
+        'orderby'        => array(
             'post_date' => 'DESC',
             'ID'        => 'DESC'
         ),
 
-        // Maybe change these later
-        'posts_per_page'         => 1,
+        // Performance
+        'suppress_filters'       => true,
         'update_post_term_cache' => false,
         'update_post_meta_cache' => false,
@@ -1508 +1509 @@
 
     // Bail if nothing passed
-    if ( empty( $parent_id ) ) {
+    if ( empty( $parent_id ) || empty( $post_type ) ) {
         return false;
     }
@@ -1521 +1522 @@
 
     $query = new WP_Query( array(
-        'fields'      => 'ids',
-        'post_parent' => $parent_id,
-        'post_status' => $post_status,
-        'post_type'   => $post_type,
-
-        // Maybe change these later
-        'posts_per_page'         => -1,
+        'fields'         => 'ids',
+        'post_parent'    => $parent_id,
+        'post_status'    => $post_status,
+        'post_type'      => $post_type,
+        'posts_per_page' => -1,
+
+        // Performance
+        'nopaging'               => true,
+        'suppress_filters'       => true,
         'update_post_term_cache' => false,
         'update_post_meta_cache' => false,
@@ -1567 +1570 @@
 
     $query = new WP_Query( array(
-        'fields'           => 'ids',
-        'suppress_filters' => true,
-        'post_parent'      => $parent_id,
-        'post_status'      => $post_status,
-        'post_type'        => $post_type,
-        'posts_per_page'   => -1,
-
-        // Maybe change these later
+        'fields'         => 'ids',
+        'post_parent'    => $parent_id,
+        'post_status'    => $post_status,
+        'post_type'      => $post_type,
+        'posts_per_page' => -1,
+        'orderby'        => array(
+            'post_date' => 'DESC',
+            'ID'        => 'DESC'
+        ),
+
+        // Performance
+        'nopaging'               => true,
+        'suppress_filters'       => true,
         'update_post_term_cache' => false,
         'update_post_meta_cache' => false,
         'ignore_sticky_posts'    => true,
-        'no_found_rows'          => true,
-        'nopaging'               => true
+        'no_found_rows'          => true
     ) );
     $child_ids = ! empty( $query->posts ) ? $query->posts : array();