Changeset 6601 for trunk/src/includes/core/abstraction.php

Timestamp:

06/23/2017 04:21:58 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Admin/Converter: Lazy load admin & converter as needed.

• Move admin class into its own file
• Remove admin.php
• Introduce _setup_ functions to make loading them on the fly easier
• Simplify converter logic for smoother starting/stopping
• Improved UI for timer/status updates
• Remove double-duty variables from BBP_Converter and response data
• Switch from text-only response value to JSON object for improved flexibility

This allows the converter to return more data, and makes it easier to work with that data.

Todo:

• Error responses
• Check that starts are bumping correctly inside of steps
• Better utilize JSON responses

File:

• trunk/src/includes/core/abstraction.php (modified) (1 diff)

trunk/src/includes/core/abstraction.php

@@ -16 +16 @@
 // Exit if accessed directly
 defined( 'ABSPATH' ) || exit;
+
+/**
+ * Setup Admin
+ *
+ * This exists outside of "/includes/admin/" because the converter may need to
+ * be setup to convert the passwords of users that were migrated from another
+ * forum platform.
+ *
+ * @since 2.6.0 bbPress (r2596)
+ */
+function bbp_setup_admin() {
+        $bbp = bbpress();
+
+        // Skip if already setup
+        if ( empty( $bbp->admin ) ) {
+
+                // Require the admin class
+                require_once $bbp->includes_dir . 'admin/classes/class-bbp-admin.php';
+
+                // Setup
+                $bbp->admin = class_exists( 'BBP_Admin' )
+                        ? new BBP_Admin()
+                        : new stdClass();
+        }
+
+        // Return the admin object
+        return $bbp->admin;
+}
+
+/**
+ * Setup Converter
+ *
+ * This exists outside of "/includes/admin/" because the converter may need to
+ * be setup to convert the passwords of users that were migrated from another
+ * forum platform.
+ *
+ * @since 2.6.0 bbPress (r2596)
+ */
+function bbp_setup_converter() {
+        $bbp_admin = bbp_setup_admin();
+
+        // Skip if already setup
+        if ( empty( $bbp_admin->converter ) ) {
+
+                // Require the converter classes
+                require_once $bbp_admin->admin_dir . 'classes/class-bbp-converter-base.php';
+                require_once $bbp_admin->admin_dir . 'classes/class-bbp-converter.php';
+
+                // Setup
+                $bbp_admin->converter = class_exists( 'BBP_Converter' )
+                        ? new BBP_Converter()
+                        : new stdClass();
+        }
+
+        // Return the converter
+        return $bbp_admin->converter;
+}
 
 /**