Changeset 6586

Timestamp:

06/19/2017 06:33:55 AM (7 years ago)

Author:

johnjamesjacoby

Message:

404: Use ! empty() over isset() to only account for true values in bbp_is_404.

This fixes broken /edit/ theme-side URLs, that will redirect otherwise.

File:

• trunk/src/includes/common/functions.php (modified) (5 diffs)

trunk/src/includes/common/functions.php

@@ -1005 +1005 @@
  * Sends notification emails for new replies to subscribed topics
  *
- * Gets new post's ID and check if there are subscribed users to that topic, and
+ * Gets new post ID and check if there are subscribed users to that topic, and
  * if there are, send notifications
  *
@@ -1012 +1012 @@
  * that limit the number of addresses in a BCC field (often to around 500.) In
  * those cases, we recommend unhooking this function and creating your own
- * custom emailer script.
+ * custom email script.
  *
  * @since 2.6.0 bbPress (r5413)
@@ -1154 +1154 @@
  * Sends notification emails for new topics to subscribed forums
  *
- * Gets new post's ID and check if there are subscribed users to that forum, and
+ * Gets new post ID and check if there are subscribed users to that forum, and
  * if there are, send notifications
  *
@@ -1161 +1161 @@
  * that limit the number of addresses in a BCC field (often to around 500.) In
  * those cases, we recommend unhooking this function and creating your own
- * custom emailer script.
+ * custom email script.
  *
  * @since 2.5.0 bbPress (r5156)
@@ -2093 +2093 @@
 
     // Custom 404 handler is set, so set posts to empty array to avoid 2 queries
-    if ( isset( $wp_query->bbp_is_404 ) ) {
+    if ( ! empty( $wp_query->bbp_is_404 ) ) {
         $posts = array();
     }