Changeset 6585 for trunk/src/includes/forums/functions.php

Timestamp:

06/19/2017 05:05:18 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Cache: make bbp_clean_post_cache() an action-only function.

Instead of calling bbp_clean_post_cache() directly, we'll call clean_post_cache() as per normal and hook bbp_clean_post_cache() to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back.

We'll also only ever update the last_changed cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the post_parent tree are dealing with the same last_changed value until the end.

This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables.

File:

• trunk/src/includes/forums/functions.php (modified) (3 diffs)

trunk/src/includes/forums/functions.php

@@ -833 +833 @@
         $bbp_db->update( $bbp_db->posts, array( 'post_status' => bbp_get_public_status_id() ), array( 'ID' => $forum_id ) );
         wp_transition_post_status( bbp_get_public_status_id(), $current_visibility, get_post( $forum_id ) );
-        bbp_clean_post_cache( $forum_id );
+        clean_post_cache( $forum_id );
     }
 
@@ -882 +882 @@
         $bbp_db->update( $bbp_db->posts, array( 'post_status' => bbp_get_private_status_id() ), array( 'ID' => $forum_id ) );
         wp_transition_post_status( bbp_get_private_status_id(), $current_visibility, get_post( $forum_id ) );
-        bbp_clean_post_cache( $forum_id );
+        clean_post_cache( $forum_id );
     }
 
@@ -931 +931 @@
         $bbp_db->update( $bbp_db->posts, array( 'post_status' => bbp_get_hidden_status_id() ), array( 'ID' => $forum_id ) );
         wp_transition_post_status( bbp_get_hidden_status_id(), $current_visibility, get_post( $forum_id ) );
-        bbp_clean_post_cache( $forum_id );
+        clean_post_cache( $forum_id );
     }