Changeset 6585 for trunk/src/includes/core/cache.php

Timestamp:

06/19/2017 05:05:18 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Cache: make bbp_clean_post_cache() an action-only function.

Instead of calling bbp_clean_post_cache() directly, we'll call clean_post_cache() as per normal and hook bbp_clean_post_cache() to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back.

We'll also only ever update the last_changed cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the post_parent tree are dealing with the same last_changed value until the end.

This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables.

File:

• trunk/src/includes/core/cache.php (modified) (3 diffs)

trunk/src/includes/core/cache.php

@@ -136 +136 @@
 function bbp_clean_post_cache( $post_id = null, $post = null ) {
 
-    // Get the post object.
-    if ( null !== $post ) {
-        $post = get_post( $post );
-    } else {
-        $post = get_post( $post_id );
-    }
-
-    // Bail if no post
-    if ( empty( $post ) ) {
-        return;
-    }
-
     // Child query types to clean
     $post_types = array(
@@ -159 +147 @@
         return;
     }
-
-    // Be sure we haven't recached the post data
-    wp_cache_delete( $post->ID, 'posts'     );
-    wp_cache_delete( $post->ID, 'post_meta' );
-
-    // Clean the term cache for the given post
-    clean_object_term_cache( $post->ID, $post->post_type );
-
-    // Bump the last_changed cache
-    wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
 
     /**
@@ -182 +160 @@
     // Invalidate parent caches
     if ( ! empty( $post->post_parent ) ) {
-        bbp_clean_post_cache( $post->post_parent );
+        clean_post_cache( $post->post_parent );
+
+    // Only bump `last_changed` when forum-root is reached
+    } else {
+        wp_cache_set( 'last_changed', microtime(), 'bbpress_posts' );
     }
 }