Changeset 6585 for trunk/src/includes/core/actions.php

Timestamp:

06/19/2017 05:05:18 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Cache: make bbp_clean_post_cache() an action-only function.

Instead of calling bbp_clean_post_cache() directly, we'll call clean_post_cache() as per normal and hook bbp_clean_post_cache() to the end of it. This reduces a bunch of superfluous cache invalidation from occurring back-to-back.

We'll also only ever update the last_changed cache key when we've reached the forum-root. This makes sure that subsequent recursive calls up the post_parent tree are dealing with the same last_changed value until the end.

This change will reduce the number of cache invalidation calls by a large amount, improving functional performance for database writes to the post & postmeta tables.

File:

• trunk/src/includes/core/actions.php (modified) (1 diff)

trunk/src/includes/core/actions.php

@@ -385 +385 @@
 add_action( 'bbp_user_edit_after', 'bbp_user_edit_after' );
 
-// New forum/topic/reply caches
-// @todo Investigate why clearing is necessary on both pre & post hooks
-add_action( 'bbp_new_forum_pre_extras',  'bbp_clean_post_cache' );
-add_action( 'bbp_new_forum_post_extras', 'bbp_clean_post_cache' );
-add_action( 'bbp_new_topic_pre_extras',  'bbp_clean_post_cache' );
-add_action( 'bbp_new_topic_post_extras', 'bbp_clean_post_cache' );
-add_action( 'bbp_new_reply_pre_extras',  'bbp_clean_post_cache' );
-add_action( 'bbp_new_reply_post_extras', 'bbp_clean_post_cache' );
-
 // Clean bbPress post caches when WordPress's is cleaned
 add_action( 'clean_post_cache', 'bbp_clean_post_cache', 10, 2 );