Changeset 6583 for trunk/tests/phpunit/testcases/core/cache.php

Timestamp:

06/19/2017 04:29:43 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Better 404 handling:

• Introduce bbp_is_404 query var, and set this in places where the default 404 condition needs to be overridden
• Introduce bbp_set_200() for cases where a default of 404 needs to be set to a 200
• Introduce bbp_get_wp_query() helper for getting the $wp_query global
• Update bbp_set_404() to accept a $query parameter to make passing the query around easier
• Update child-ids queries to use the last_changed cache to reduce the amount of cache churn when cleaning

Fixes #3047. See #1973.

File:

• trunk/tests/phpunit/testcases/core/cache.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/core/cache.php

@@ -8 +8 @@
 
     /**
+     * @group jjj
      * @covers ::bbp_clean_post_cache
      */
@@ -14 +15 @@
         // Get the topic post type.
         $tpt = bbp_get_topic_post_type();
+        $rpt = bbp_get_topic_post_type();
 
         // Set up a forum with 1 topic and 1 reply to that topic.
@@ -33 +35 @@
         // Make sure we've cached some data.
         bbp_get_all_child_ids( $f, $tpt );
-        bbp_get_all_child_ids( $t, $tpt );
+        bbp_get_all_child_ids( $t, $rpt );
 
-        $this->assertEquals( array( $t ), wp_cache_get( "bbp_parent_all_{$f}_type_{$tpt}_child_ids", 'bbpress_posts' ) );
-        $this->assertEquals( array( $r ), wp_cache_get( "bbp_parent_all_{$t}_type_{$tpt}_child_ids", 'bbpress_posts' ) );
+        // Setup
+        $f_key        = md5( serialize( array( 'parent_id' => $f, 'post_type' => $tpt ) ) );
+        $t_key        = md5( serialize( array( 'parent_id' => $t, 'post_type' => $rpt ) ) );
+        $last_changed = wp_cache_get_last_changed( 'bbpress_posts' );
+        
+        // Keys
+        $f_key = "bbp_child_ids:{$f_key}:{$last_changed}";
+        $t_key = "bbp_child_ids:{$t_key}:{$last_changed}";
+
+        $this->assertEquals( array( $t ), wp_cache_get( $f_key, 'bbpress_posts' ) );
+        $this->assertEquals( array( $r ), wp_cache_get( $t_key, 'bbpress_posts' ) );
 
         // Clean the cache.
         bbp_clean_post_cache( $r );
 
-        $this->assertEquals( false, wp_cache_get( "bbp_parent_all_{$f}_type_{$tpt}_child_ids", 'bbpress_posts' ) );
-        $this->assertEquals( false, wp_cache_get( "bbp_parent_all_{$t}_type_{$tpt}_child_ids", 'bbpress_posts' ) );
+        // Setup
+        $last_changed = wp_cache_get_last_changed( 'bbpress_posts' );
+        
+        // Keys
+        $f_key = "bbp_child_ids:{$f_key}:{$last_changed}";
+        $t_key = "bbp_child_ids:{$t_key}:{$last_changed}";
+
+        $this->assertEquals( false, wp_cache_get( $f_key, 'bbpress_posts' ) );
+        $this->assertEquals( false, wp_cache_get( $t_key, 'bbpress_posts' ) );
     }
 }