Changeset 6583 for trunk/src/includes/core/theme-compat.php

Timestamp:

06/19/2017 04:29:43 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Better 404 handling:

• Introduce bbp_is_404 query var, and set this in places where the default 404 condition needs to be overridden
• Introduce bbp_set_200() for cases where a default of 404 needs to be set to a 200
• Introduce bbp_get_wp_query() helper for getting the $wp_query global
• Update bbp_set_404() to accept a $query parameter to make passing the query around easier
• Update child-ids queries to use the last_changed cache to reduce the amount of cache churn when cleaning

Fixes #3047. See #1973.

File:

• trunk/src/includes/core/theme-compat.php (modified) (3 diffs)

trunk/src/includes/core/theme-compat.php

@@ -395 +395 @@
             'is_single'             => false,
             'is_archive'            => false,
-            'is_tax'                => false,
+            'is_tax'                => false
         ), 'theme_compat_reset_post' );
     } else {
@@ -428 +428 @@
             'is_single'             => false,
             'is_archive'            => false,
-            'is_tax'                => false,
+            'is_tax'                => false
         ), 'theme_compat_reset_post' );
     }
@@ -458 +458 @@
     // Clean up the dummy post
     unset( $dummy );
-
-    /**
-     * Force the header back to 200 status if not a deliberate 404
-     *
-     * @see https://bbpress.trac.wordpress.org/ticket/1973
-     */
-    if ( ! $wp_query->is_404() ) {
-        status_header( 200 );
-    }
 
     // If we are resetting a post, we are in theme compat