Changeset 6574 for trunk/src/includes/users/capabilities.php

Timestamp:

06/16/2017 09:32:57 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Super Moderators: Compare the user ID to $args[0] instead.

This change makes sure the proper user IDs are compared, and also prevents super moderators from editing Keymasters (demotions can't come from users with a less capable role than their own.)

File:

• trunk/src/includes/users/capabilities.php (modified) (1 diff)

trunk/src/includes/users/capabilities.php

@@ -121 +121 @@
 
                 // Users can always edit themselves, so only map for others
-                if ( bbp_get_current_user_id() !== $user_id ) {
-                    $caps = array( 'moderate' );
+                if ( ! empty( $args[0] ) && ( $args[0] !== $user_id ) ) {
+
+                    // Super moderators cannot edit keymasters
+                    if ( ! bbp_is_user_keymaster( $args[0] ) ) {
+                        $caps = array( 'moderate' );
+                    }
                 }
             }