Changeset 6571 for trunk/src/includes/replies/capabilities.php

Timestamp:

06/16/2017 07:45:05 PM (7 years ago)

Author:

johnjamesjacoby

Message:

Capabilities: Logic improvements to help with per-forum moderation.

• Introduce moderate_forum capability check, used to check if a user has the ability to moderate a specific forum
• Limit number of direct keep_gate checks, and use bbp_is_user_keymaster() where possible
• Make bbp_is_user_forum_moderator() check the new moderate_forum mapped capability
• Have the moderate mapped capability check moderate_forum if the $args[0] can be bubbled up to being a forum ID
• Map admin post-type areas to their appropriate edit_ capabilities – they are now properly handled via other mapped conditions

This change (along with r6567 & r6569) allows private & hidden forums to appear in forums queries for users who can moderate them.

File:

• trunk/src/includes/replies/capabilities.php (modified) (3 diffs)

trunk/src/includes/replies/capabilities.php

@@ -43 +43 @@
  * @uses get_post_type_object() To get the post type object
  * @uses bbp_get_public_status_id() To get the public status id
- * @uses bbp_is_user_forum_moderator() To check if the user is a forum moderator
- * @uses bbp_get_reply_forum_id() To get the repliy forum id
+ * @uses bbp_get_reply_forum_id() To get the reply forum id
  * @uses apply_filters() Filter mapped results
  *
@@ -181 +180 @@
                 // Moderators can always edit forum content
                 } elseif ( user_can( $user_id, 'moderate', $_post->ID ) ) {
-                     $caps = array( 'spectate' );
+                    $caps = array( 'spectate' );
 
                 // Unknown so map to delete_others_posts
@@ -205 +204 @@
 
         case 'bbp_replies_admin' :
-            $caps = array( 'moderate' );
+            $caps = array( 'edit_replies' );
             break;
     }