Changeset 6571

Timestamp:

06/16/2017 07:45:05 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Capabilities: Logic improvements to help with per-forum moderation.

• Introduce moderate_forum capability check, used to check if a user has the ability to moderate a specific forum
• Limit number of direct keep_gate checks, and use bbp_is_user_keymaster() where possible
• Make bbp_is_user_forum_moderator() check the new moderate_forum mapped capability
• Have the moderate mapped capability check moderate_forum if the $args[0] can be bubbled up to being a forum ID
• Map admin post-type areas to their appropriate edit_ capabilities – they are now properly handled via other mapped conditions

This change (along with r6567 & r6569) allows private & hidden forums to appear in forums queries for users who can moderate them.

Location:

trunk/src/includes

Files:

• forums/capabilities.php (modified) (5 diffs)
• replies/capabilities.php (modified) (3 diffs)
• topics/capabilities.php (modified) (2 diffs)
• users/capabilities.php (modified) (3 diffs)

trunk/src/includes/forums/capabilities.php

@@ -108 +108 @@
             break;
 
+        /** Moderating ********************************************************/
+
+        case 'moderate_forum' :
+
+            // Get the post
+            $_post = get_post( $args[0] );
+            if ( ! empty( $_post ) && bbp_allow_forum_mods() ) {
+
+                // Make sure feature is enabled & user is mod on this forum
+                if ( bbp_is_object_of_user( $_post->ID, $user_id, '_bbp_moderator_id' ) ) {
+                    $caps = array( 'spectate' );
+                }
+            }
+
+            break;
+
         /** Publishing ********************************************************/
 
@@ -126 +142 @@
 
             // Moderators can always edit
-            if ( user_can( $user_id, 'keep_gate' ) ) {
-                $caps = array( 'keep_gate' );
+            if ( bbp_is_user_keymaster( $user_id ) ) {
+                $caps = array( 'spectate' );
 
             // Otherwise, block
@@ -150 +166 @@
                     $caps = array( 'do_not_allow' );
 
+                // Moderators can always read forum content
+                } elseif ( user_can( $user_id, 'moderate', $_post->ID ) ) {
+                    $caps = array( 'spectate' );
+
                 // User is author so allow edit if not in admin
                 } elseif ( ! is_admin() && ( (int) $user_id === (int) $_post->post_author ) ) {
                     $caps = array( $post_type->cap->edit_posts );
-
-                // Moderators can always read forum content
-                } elseif ( user_can( $user_id, 'moderate', $_post->ID ) ) {
-                    $caps = array( 'spectate' );
 
                 // Unknown, so map to edit_others_posts
@@ -198 +214 @@
         // Forum admin area.
         case 'bbp_forums_admin' :
-            $caps = array( 'keep_gate' );
+            $caps = array( 'edit_forums' );
             break;
     }
@@ -248 +264 @@
  */
 function bbp_is_user_forum_moderator( $user_id = 0, $forum_id = 0 ) {
-
-    // Validate user ID - fallback to current user if no ID passed.
-    $user_id  = bbp_get_user_id( $user_id, false, ! empty( $user_id ) );
+    $user_id  = bbp_get_user_id( $user_id, false, empty( $user_id ) );
     $forum_id = bbp_get_forum_id( $forum_id );
-
-    // Check if per-forum moderation is enabled, or assume false
-    $retval = bbp_allow_forum_mods()
-        ? bbp_is_object_of_user( $forum_id, $user_id, '_bbp_moderator_id' )
-        : false;
+    $retval   = user_can( $user_id, 'moderate_forum', $forum_id );
 
     // Filter & return

trunk/src/includes/replies/capabilities.php

@@ -43 +43 @@
  * @uses get_post_type_object() To get the post type object
  * @uses bbp_get_public_status_id() To get the public status id
- * @uses bbp_is_user_forum_moderator() To check if the user is a forum moderator
- * @uses bbp_get_reply_forum_id() To get the repliy forum id
+ * @uses bbp_get_reply_forum_id() To get the reply forum id
  * @uses apply_filters() Filter mapped results
  *
@@ -181 +180 @@
                 // Moderators can always edit forum content
                 } elseif ( user_can( $user_id, 'moderate', $_post->ID ) ) {
-                     $caps = array( 'spectate' );
+                    $caps = array( 'spectate' );
 
                 // Unknown so map to delete_others_posts
@@ -205 +204 @@
 
         case 'bbp_replies_admin' :
-            $caps = array( 'moderate' );
+            $caps = array( 'edit_replies' );
             break;
     }

trunk/src/includes/topics/capabilities.php

@@ -63 +63 @@
  * @uses get_post_type_object() To get the post type object
  * @uses bbp_get_public_status_id() To get the  public status id
- * @uses bbp_is_user_forum_moderator() To check if the user is a forum moderator
- * @uses bbp_get_topic_forum_id() To get the opic forum id
+ * @uses bbp_get_topic_forum_id() To get the topic forum id
  * @uses apply_filters() Filter capability map results
  *
@@ -225 +224 @@
 
         case 'bbp_topics_admin' :
-            $caps = array( 'moderate' );
+            $caps = array( 'edit_topics' );
             break;
     }

trunk/src/includes/users/capabilities.php

@@ -65 +65 @@
                 $caps = array( 'do_not_allow' );
 
+            // Keymasters can always moderate
+            } elseif ( bbp_is_user_keymaster( $user_id ) ) {
+                $caps = array( 'spectate' );
+
             // Default to the current cap.
             } else {
@@ -685 +689 @@
 function bbp_is_user_active( $user_id = 0 ) {
 
-    // Default to current user
-    if ( empty( $user_id ) && is_user_logged_in() ) {
-        $user_id = bbp_get_current_user_id();
-    }
-
     // No user to check
+    $user_id = bbp_get_user_id( $user_id, false, true );
     if ( empty( $user_id ) ) {
         return false;
@@ -732 +732 @@
  */
 function bbp_is_user_keymaster( $user_id = 0 ) {
-
-    // Default to current user ID if none is passed
     $_user_id = bbp_get_user_id( $user_id, false, true );
-
-    // Check the 'keep_gate' capability
     $retval   = user_can( $_user_id, 'keep_gate' );