Changeset 6544 for trunk/src/includes/topics/functions.php

Timestamp:

06/14/2017 06:45:49 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Performance: Last pass at 2.6 performance tuning.

• Keep a local cache of non-options that aren't in the database, to avoid multiple database misses for options we know aren't in the database after wp_load_alloptions() is called
• Stop getting all favorite IDs and subscription IDs when checking if a user has favorited or subscribed to something, because these queries are expensive joins that are difficult to cache & invalidate
• Consolidate forum/topic favorites & subscriptions logic back into central routers, to make it easier to handle taxonomy term subscriptions in the future, and remove nested filter calls that make the call-stack confusing
• Informally deprecate some forum & topic specific fav/sub functions
• Rename one of the engagements remove functions to better match existing naming pattern
• Typo fixes & general code quality improvements
• Bump slow tests threshold up to 500 for now, and we can bring back down later (my 12" MacBook runs this pretty slowly, so I'd like to play with this more)
• Unit tests are all passing, and more quickly, maybe surprisingly

This should result in around 20 fewer database hits on non-persistent-cache sites, on average. When viewing single topics & replies, this will result in more than 25 fewer database hits.

File:

• trunk/src/includes/topics/functions.php (modified) (3 diffs)

trunk/src/includes/topics/functions.php

@@ -2381 +2381 @@
 
 /**
- * Remove a deleted topic from all users' favorites
+ * Remove a deleted topic from all user favorites
  *
  * @since 2.0.0 bbPress (r2652)
@@ -2414 +2414 @@
 
 /**
- * Remove a deleted topic from all users' subscriptions
+ * Remove a deleted topic from all user subscriptions
  *
  * @since 2.0.0 bbPress (r2652)
@@ -2431 +2431 @@
     }
 
+    // Bail if no topic
     $topic_id = bbp_get_topic_id( $topic_id );
-
-    // Bail if no topic
     if ( empty( $topic_id ) ) {
         return;
     }
 
-    // Get users
-    $users = (array) bbp_get_topic_subscribers( $topic_id );
-
-    // Users exist
-    if ( ! empty( $users ) ) {
-
-        // Loop through users
-        foreach ( $users as $user ) {
-
-            // Remove each user
-            bbp_remove_user_subscription( $user, $topic_id );
-        }
-    }
+    // Remove all users
+    return bbp_remove_object_from_all_users( $topic_id, '_bbp_subscription', 'post' );
 }