Changeset 6534 for trunk/src/includes/replies/functions.php

Timestamp:

06/12/2017 09:23:32 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Revert part of r6525, and adjust some actions.

• Engagements will need to be "public only" for 2.6, and we can reconsider what private/hidden engagements look like later
• Make sure that engagements are saved before voice counts are done
• Use new is_public style wrapper function for topics & replies where appropriate
• Remove a few current_filter() checks that should no longer be necessary with current action hook implementation
• There may be more clean-up necessary here, but this is required to bring all unit-tests back to passing as they've been written, specifically things hooked to the bbp_insert_topic and bbp_insert_reply hooks

See #3068. Hat-tip netweb.

File:

• trunk/src/includes/replies/functions.php (modified) (1 diff)

trunk/src/includes/replies/functions.php

@@ -109 +109 @@
 
     // If the reply is public, update the forum/topic reply counts.
-    if ( bbp_get_reply_status( $reply_id ) === bbp_get_public_status_id() ) {
+    if ( bbp_is_reply_published( $reply_id ) ) {
         bbp_increase_topic_reply_count( $topic_id );
-        bbp_increase_forum_reply_count( $forum_id );
+        bbp_increase_forum_reply_count( $reply_id );
 
     // If the reply isn't public only update the topic reply hidden count.