Changeset 6529 for trunk/src/includes/topics/functions.php

Timestamp:

06/12/2017 05:41:49 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Keep topic engagement counts up-to-date.

This changes the way the old 'voice count' works with the new engagements API in the following ways:

• Introduce new function to update voice count meta when necessary
• Modify recalculation function with a $force parameter, and only recalculate the counts when the engagements have changed by default
• Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.)
• We are silently moving the bbp_delete_ actions onto the before_delete_post hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528)

Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree.

See: #3068.

File:

• trunk/src/includes/topics/functions.php (modified) (5 diffs)

trunk/src/includes/topics/functions.php

@@ -944 +944 @@
         if ( empty( $forum_id )  ) {
             $forum_id = bbp_get_topic_forum_id( $topic_id );
-
-            // Make every effort to get forum id
-            // https://bbpress.trac.wordpress.org/ticket/2529
-            if ( empty( $forum_id ) && ( current_filter() === 'bbp_deleted_topic' ) ) {
-                $forum_id = get_post_field( 'post_parent', $topic_id );
-            }
         }
 
@@ -2983 +2977 @@
 function bbp_update_topic_voice_count( $topic_id = 0 ) {
 
-    // Get the old voices
+    // If it's a reply, then get the parent (topic id)
+    $topic_id = bbp_is_reply( $topic_id )
+        ? bbp_get_reply_topic_id( $topic_id )
+        : bbp_get_topic_id( $topic_id );
+
+    // Bail if no topic ID
+    if ( empty( $topic_id ) ) {
+        return;
+    }
+
+    // Count the engagements
     $count = count( bbp_get_topic_engagements( $topic_id ) );
 
@@ -3874 +3878 @@
  * Called after deleting a topic
  *
+ * @since 2.0.0 bbPress (r2993)
+ *
  * @uses bbp_get_topic_id() To get the topic id
  * @uses bbp_is_topic() To check if the passed id is a topic
@@ -3891 +3897 @@
  * Called after trashing a topic
  *
+ * @since 2.0.0 bbPress (r2993)
+ *
  * @uses bbp_get_topic_id() To get the topic id
  * @uses bbp_is_topic() To check if the passed id is a topic
@@ -3907 +3915 @@
 /**
  * Called after untrashing a topic
+ *
+ * @since 2.0.0 bbPress (r2993)
  *
  * @uses bbp_get_topic_id() To get the topic id