Changeset 6529 for trunk/src/includes/replies/functions.php

Timestamp:

06/12/2017 05:41:49 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Keep topic engagement counts up-to-date.

This changes the way the old 'voice count' works with the new engagements API in the following ways:

• Introduce new function to update voice count meta when necessary
• Modify recalculation function with a $force parameter, and only recalculate the counts when the engagements have changed by default
• Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.)
• We are silently moving the bbp_delete_ actions onto the before_delete_post hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528)

Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree.

See: #3068.

File:

• trunk/src/includes/replies/functions.php (modified) (4 diffs)

trunk/src/includes/replies/functions.php

@@ -964 +964 @@
         if ( empty( $topic_id ) ) {
             $topic_id = bbp_get_reply_topic_id( $reply_id );
-
-            // Make every effort to get topic id
-            // https://bbpress.trac.wordpress.org/ticket/2529
-            if ( empty( $topic_id ) && ( current_filter() === 'bbp_deleted_reply' ) ) {
-                $topic_id = get_post_field( 'post_parent', $reply_id );
-            }
         }
 
@@ -2065 +2059 @@
  * Called after deleting a reply
  *
+ * @since 2.0.0 bbPress (r2993)
+ *
  * @uses bbp_get_reply_id() To get the reply id
  * @uses bbp_is_reply() To check if the passed id is a reply
@@ -2082 +2078 @@
  * Called after trashing a reply
  *
+ * @since 2.0.0 bbPress (r2993)
+ *
  * @uses bbp_get_reply_id() To get the reply id
  * @uses bbp_is_reply() To check if the passed id is a reply
@@ -2098 +2096 @@
 /**
  * Called after untrashing (restoring) a reply
+ *
+ * @since 2.0.0 bbPress (r2993)
  *
  * @uses bbp_get_reply_id() To get the reply id