Changeset 6529 for trunk/src/includes/core/actions.php

Timestamp:

06/12/2017 05:41:49 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Keep topic engagement counts up-to-date.

This changes the way the old 'voice count' works with the new engagements API in the following ways:

• Introduce new function to update voice count meta when necessary
• Modify recalculation function with a $force parameter, and only recalculate the counts when the engagements have changed by default
• Hook the above functions in where appropriate, largely when deleting replies (this is a unique case where a fully deleted reply needs to check if the author of the current reply has a previously public reply in that same topic already, which should not trigger a recalculation.)
• We are silently moving the bbp_delete_ actions onto the before_delete_post hook, so that all term & meta-data is available to them (which helps with race conditions mentioned in r6528)

Engagements are now hooked in and listening in the most efficient way possible, at least until a common & shared walker is introduced for the entire tree.

See: #3068.

File:

• trunk/src/includes/core/actions.php (modified) (6 diffs)

trunk/src/includes/core/actions.php

@@ -155 +155 @@
 
 // Before Delete/Trash/Untrash Forum
-add_action( 'wp_trash_post', 'bbp_trash_forum'   );
-add_action( 'trash_post',    'bbp_trash_forum'   );
-add_action( 'untrash_post',  'bbp_untrash_forum' );
-add_action( 'delete_post',   'bbp_delete_forum'  );
+add_action( 'wp_trash_post',      'bbp_trash_forum'   );
+add_action( 'trash_post',         'bbp_trash_forum'   );
+add_action( 'untrash_post',       'bbp_untrash_forum' );
+add_action( 'before_delete_post', 'bbp_delete_forum'  );
 
 // After Deleted/Trashed/Untrashed Forum
@@ -184 +184 @@
 
 // Before Delete/Trash/Untrash Reply
-add_action( 'wp_trash_post', 'bbp_trash_reply'   );
-add_action( 'trash_post',    'bbp_trash_reply'   );
-add_action( 'untrash_post',  'bbp_untrash_reply' );
-add_action( 'delete_post',   'bbp_delete_reply'  );
+add_action( 'wp_trash_post',      'bbp_trash_reply'   );
+add_action( 'trash_post',         'bbp_trash_reply'   );
+add_action( 'untrash_post',       'bbp_untrash_reply' );
+add_action( 'before_delete_post', 'bbp_delete_reply'  );
 
 // After Deleted/Trashed/Untrashed Reply
@@ -206 +206 @@
 
 // Before Delete/Trash/Untrash Topic
-add_action( 'wp_trash_post', 'bbp_trash_topic'   );
-add_action( 'trash_post',    'bbp_trash_topic'   );
-add_action( 'untrash_post',  'bbp_untrash_topic' );
-add_action( 'delete_post',   'bbp_delete_topic'  );
+add_action( 'wp_trash_post',      'bbp_trash_topic'   );
+add_action( 'trash_post',         'bbp_trash_topic'   );
+add_action( 'untrash_post',       'bbp_untrash_topic' );
+add_action( 'before_delete_post', 'bbp_delete_topic'  );
 
 // After Deleted/Trashed/Untrashed Topic
@@ -293 +293 @@
 add_action( 'bbp_unapproved_reply', 'bbp_decrease_topic_reply_count'        );
 add_action( 'bbp_unapproved_reply', 'bbp_increase_topic_reply_count_hidden' );
+add_action( 'bbp_deleted_reply',    'bbp_decrease_topic_reply_count_hidden' );
 
 // Users topic & reply counts.
@@ -310 +311 @@
 add_action( 'bbp_insert_reply', 'bbp_insert_reply_update_counts', 10, 3 );
 
-// Update topic voice counts.
+// Update engagements.
+add_action( 'bbp_new_topic', 'bbp_update_topic_engagements' );
+add_action( 'bbp_new_reply', 'bbp_update_topic_engagements' );
+
+// Recalculate engagements.
+add_action( 'bbp_deleted_topic', 'bbp_recalculate_topic_engagements' );
+add_action( 'bbp_deleted_reply', 'bbp_recalculate_topic_engagements' );
+
+// Update engagement counts.
 add_action( 'bbp_new_reply',        'bbp_update_topic_voice_count' );
 add_action( 'bbp_trashed_reply',    'bbp_update_topic_voice_count' );
@@ -318 +327 @@
 add_action( 'bbp_approved_reply',   'bbp_update_topic_voice_count' );
 add_action( 'bbp_unapproved_reply', 'bbp_update_topic_voice_count' );
+add_action( 'bbp_deleted_reply',    'bbp_update_topic_voice_count' );
 
 // Insert reply voice counts.