Changeset 6525 for trunk/src/includes/users/engagements.php

Timestamp:

06/12/2017 02:10:58 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Tracking is not just for public or closed topics.

This commit updates the engagement upgrade tool and recalculation helper functions to not be limited to public & closed post statuses. Engagements can happen on private or hidden topics also, including trash, spam, and so on.

The non-visible topics that a user is engaged in should be filtered out as needed when queried based on post_status or other various meta-data.

See #3068.

File:

• trunk/src/includes/users/engagements.php (modified) (2 diffs)

trunk/src/includes/users/engagements.php

@@ -196 +196 @@
         $topic_id = bbp_get_topic_id( $topic_id );
         $bbp_db   = bbp_db();
-        $statii   = "'" . implode( "', '", bbp_get_public_topic_statuses() ) . "'";
 
         // A cool UNION query!
@@ -202 +201 @@
 SELECT DISTINCT( post_author ) FROM (
         SELECT post_author FROM {$bbp_db->posts}
-                WHERE ( ID = %d AND post_status IN ({$statii}) AND post_type = %s )
+                WHERE ( ID = %d AND post_type = %s )
 UNION
         SELECT post_author FROM {$bbp_db->posts}
-                WHERE ( post_parent = %d AND post_status = %s AND post_type = %s )
+                WHERE ( post_parent = %d AND post_type = %s )
 ) as u1";
 
         // Prepare & get results
-        $query   = $bbp_db->prepare( $sql, $topic_id, bbp_get_topic_post_type(), $topic_id, bbp_get_public_status_id(), bbp_get_reply_post_type() );
+        $query   = $bbp_db->prepare( $sql, $topic_id, bbp_get_topic_post_type(), $topic_id, bbp_get_reply_post_type() );
         $results = $bbp_db->get_col( $query );