Changeset 6525 for trunk/src/includes/admin/tools/upgrade.php

Timestamp:

06/12/2017 02:10:58 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Tracking is not just for public or closed topics.

This commit updates the engagement upgrade tool and recalculation helper functions to not be limited to public & closed post statuses. Engagements can happen on private or hidden topics also, including trash, spam, and so on.

The non-visible topics that a user is engaged in should be filtered out as needed when queried based on post_status or other various meta-data.

See #3068.

File:

• trunk/src/includes/admin/tools/upgrade.php (modified) (2 diffs)

trunk/src/includes/admin/tools/upgrade.php

@@ -178 +178 @@
     $tpt = bbp_get_topic_post_type();
     $rpt = bbp_get_reply_post_type();
-    $pps = bbp_get_public_status_id();
-    $cps = bbp_get_closed_status_id();
-    $sql = $bbp_db->prepare( "INSERT INTO {$bbp_db->postmeta} (post_id, meta_key, meta_value) (
+    $sql = "INSERT INTO {$bbp_db->postmeta} (post_id, meta_key, meta_value) (
             SELECT postmeta.meta_value, '_bbp_engagement', posts.post_author
                 FROM {$bbp_db->posts} AS posts
@@ -187 +185 @@
                     AND postmeta.meta_key = '_bbp_topic_id'
                 WHERE posts.post_type IN (%s, %s)
-                    AND posts.post_status IN (%s, %s)
-                GROUP BY postmeta.meta_value, posts.post_author)", $tpt, $rpt, $pps, $cps );
+                GROUP BY postmeta.meta_value, posts.post_author)";
 
     // Run the big query
-    $prepare     = $bbp_db->prepare( $sql, $tpt, $rpt, $pps, $cps );
+    $prepare     = $bbp_db->prepare( $sql, $tpt, $rpt );
     $engagements = $bbp_db->query( $prepare );