Changeset 6516 for trunk/src/includes/topics/functions.php

Timestamp:

06/10/2017 07:25:42 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Engagements: Update bbp_update_topic_voice_count() to only count the number of existing engagements.

Recalculating the entire engagement tree for each topic is costly, should be done in its own dedicated function, and then only hooked in or executed when absolutely necessary.

This is easier to do with the engagements API that's new in 2.6. Recalculation function imminent.

See #3068.

File:

• trunk/src/includes/topics/functions.php (modified) (2 diffs)

trunk/src/includes/topics/functions.php

@@ -2965 +2965 @@
  *
  * @since 2.0.0 bbPress (r2567)
+ * @since 2.6.0 bbPress (r6515) This must be called after any engagement changes
  *
  * @param int $topic_id Optional. Topic id to update
@@ -2982 +2983 @@
 function bbp_update_topic_voice_count( $topic_id = 0 ) {
 
-    // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) ) {
-        $topic_id = bbp_get_reply_topic_id( $topic_id );
-    } elseif ( bbp_is_topic( $topic_id ) ) {
-        $topic_id = bbp_get_topic_id( $topic_id );
-    } else {
-        return;
-    }
-
-    // Query the DB to get voices in this topic
-    // See: https://bbpress.trac.wordpress.org/ticket/3083
-    $bbp_db  = bbp_db();
-    $sql     = "SELECT DISTINCT( post_author ) FROM (
-                    SELECT post_author FROM {$bbp_db->posts}
-                        WHERE ( ID = %d AND post_type = %s )
-                    UNION
-                    SELECT post_author FROM {$bbp_db->posts}
-                        WHERE ( post_parent = %d AND post_status = %s AND post_type = %s )
-                ) as u1";
-    $query   = $bbp_db->prepare( $sql, $topic_id, bbp_get_topic_post_type(), $topic_id, bbp_get_public_status_id(), bbp_get_reply_post_type() );
-    $results = $bbp_db->get_col( $query );
-
-    // Parse results into voices
-    $new_voices  = ! is_wp_error( $results )
-        ? wp_parse_id_list( array_filter( $results ) )
-        : array();
-
     // Get the old voices
-    $old_voices = bbp_get_topic_engagements( $topic_id );
-
-    // Get the count
-    $new_count = count( $new_voices );
-    $old_count = count( $old_voices );
-
-    // Only recalculate if count is different
-    if ( $new_count !== $old_count ) {
-
-        // Delete all engagements
-        delete_post_meta( $topic_id, '_bbp_engagement' );
-
-        // Update the voice count for this topic id
-        foreach ( $new_voices as $user_id ) {
-            bbp_add_user_engagement( $user_id, $topic_id );
-        }
-    }
+    $count = count( bbp_get_topic_engagements( $topic_id ) );
 
     // Update the voice count for this topic id
-    update_post_meta( $topic_id, '_bbp_voice_count', $new_count );
+    update_post_meta( $topic_id, '_bbp_voice_count', $count );
 
     // Filter & return
-    return (int) apply_filters( 'bbp_update_topic_voice_count', $new_count, $topic_id );
+    return (int) apply_filters( 'bbp_update_topic_voice_count', $count, $topic_id );
 }