Changeset 6492 for branches/2.5/includes/extend/buddypress/activity.php

Timestamp:

06/06/2017 05:57:15 AM (6 years ago)

Author:

netweb

Message:

BuddyPress: Check for missing activity component when looking for an activity stream item.

This changeset fixes a bug that would result in duplicate activity stream items when editing a topic or reply.

Props r-a-y.
Fixes #2690.

Merges [5857] to the 2.5 branch.

File:

• branches/2.5/includes/extend/buddypress/activity.php (modified) (1 diff)

branches/2.5/includes/extend/buddypress/activity.php

@@ -275 +275 @@
 
         // Get the activity stream item, bail if it doesn't exist
-        $existing = bp_activity_get_specific( array( 'activity_ids' => $activity_id, 'show_hidden' => true, 'spam' => 'all', ) );
-        if ( empty( $existing['total'] ) || ( 1 !== (int) $existing['total'] ) )
+        $existing = new BP_Activity_Activity( $activity_id );
+        if ( empty( $existing->component ) ) {
             return null;
+        }
 
         // Return the activity ID since we've verified the connection