Changeset 6481

Timestamp:

06/04/2017 09:34:59 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Tools: Introduce bbp_get_unique_array_values() helper function.

Use this when parsing private/hidden forum IDs for saving.

Location:

trunk/src/includes

Files:

• common/functions.php (modified) (1 diff)
• forums/functions.php (modified) (6 diffs)

trunk/src/includes/common/functions.php

@@ -123 +123 @@
 
 /** Misc **********************************************************************/
+
+/**
+ * Return the unique non-empty values of an array.
+ *
+ * @since 2.6.0 bbPress (r6481)
+ *
+ * @param array $array Array to get values of
+ *
+ * @return array
+ */
+function bbp_get_unique_array_values( $array = array() ) {
+    return array_unique( array_filter( array_values( $array ) ) );
+}
 
 /**

trunk/src/includes/forums/functions.php

@@ -871 +871 @@
 
         // Update private forums minus this one
-        update_option( '_bbp_private_forums', array_unique( array_filter( array_values( $private ) ) ) );
+        update_option( '_bbp_private_forums', bbp_get_unique_array_values( $private ) );
     }
 
@@ -886 +886 @@
 
         // Update hidden forums minus this one
-        update_option( '_bbp_hidden_forums', array_unique( array_filter( array_values( $hidden ) ) ) );
+        update_option( '_bbp_hidden_forums', bbp_get_unique_array_values( $hidden ) );
     }
 
@@ -932 +932 @@
 
             // Update hidden forums minus this one
-            update_option( '_bbp_hidden_forums', array_unique( array_filter( array_values( $hidden ) ) ) );
+            update_option( '_bbp_hidden_forums', bbp_get_unique_array_values( $hidden ) );
         }
 
@@ -938 +938 @@
         $private   = bbp_get_private_forum_ids();
         $private[] = $forum_id;
-        update_option( '_bbp_private_forums', array_unique( array_filter( array_values( $private ) ) ) );
+        update_option( '_bbp_private_forums', bbp_get_unique_array_values( $private ) );
 
         // Update forums visibility setting
@@ -982 +982 @@
 
             // Update private forums minus this one
-            update_option( '_bbp_private_forums', array_unique( array_filter( array_values( $private ) ) ) );
+            update_option( '_bbp_private_forums', bbp_get_unique_array_values( $private ) );
         }
 
@@ -988 +988 @@
         $hidden   = bbp_get_hidden_forum_ids();
         $hidden[] = $forum_id;
-        update_option( '_bbp_hidden_forums', array_unique( array_filter( array_values( $hidden ) ) ) );
+        update_option( '_bbp_hidden_forums', bbp_get_unique_array_values( $hidden ) );
 
         // Update forums visibility setting