Skip to:
Content

bbPress.org

Changeset 6447


Ignore:
Timestamp:
06/01/2017 05:49:34 PM (8 years ago)
Author:
johnjamesjacoby
Message:

Converter: Refresh to registered settings

  • ksort() the Platform list, and exclude "Example" since it's not usable
  • Turn some text fields into number fields, with reasonable boundaries
  • Add code classes to database fields
  • Update some labels & descriptions

Fixes #3095.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/includes/admin/settings.php

    r6443 r6447  
    14351435function bbp_converter_setting_callback_platform() {
    14361436
    1437     $platform_options = '';
    1438     $curdir           = opendir( bbpress()->admin->admin_dir . 'converters/' );
    1439 
    14401437    // Bail if no directory was found (how did this happen?)
     1438    $curdir = opendir( bbpress()->admin->admin_dir . 'converters/' );
    14411439    if ( empty( $curdir ) ) {
    14421440        return;
    14431441    }
    14441442
     1443    // Default values
     1444    $platform_options = '';
     1445    $files            = array();
     1446
    14451447    // Loop through files in the converters folder and assemble some options
    14461448    while ( $file = readdir( $curdir ) ) {
    14471449        if ( ( stristr( $file, '.php' ) ) && ( stristr( $file, 'index' ) === false ) ) {
    1448             $file              = preg_replace( '/.php/', '', $file );
    1449             $platform_options .= '<option value="' . esc_attr( $file ) . '">' . esc_html( $file ) . '</option>';
     1450
     1451            // Get the file name, without the extension
     1452            $name = preg_replace( '/.php/', '', $file );
     1453
     1454            // Skip the 'Example' converter is this list
     1455            if ( 'Example' !== $name ) {
     1456                $files[] = $name;
     1457            }
    14501458        }
    14511459    }
    14521460
    1453     closedir( $curdir ); ?>
     1461    // Close the directory
     1462    closedir( $curdir );
     1463
     1464    // Resort files alphabetically
     1465    ksort( $files );
     1466
     1467    // Put options together
     1468    foreach ( $files as $file ) {
     1469        $platform_options .= '<option value="' . esc_attr( $file ) . '">' . esc_html( $file ) . '</option>';
     1470    } ?>
    14541471
    14551472    <select name="_bbp_converter_platform" id="_bbp_converter_platform" /><?php echo $platform_options ?></select>
    … …  
    14671484?>
    14681485
    1469     <input name="_bbp_converter_db_server" id="_bbp_converter_db_server" type="text" value="<?php bbp_form_option( '_bbp_converter_db_server', 'localhost' ); ?>" class="medium-text" />
    1470     <label for="_bbp_converter_db_server"><?php esc_html_e( 'IP or hostname', 'bbpress' ); ?></label>
     1486    <input name="_bbp_converter_db_server" id="_bbp_converter_db_server" type="text" class="code" value="<?php bbp_form_option( '_bbp_converter_db_server', 'localhost' ); ?>" class="medium-text" />
     1487    <label for="_bbp_converter_db_server"><?php esc_html_e( 'Use default "localhost" if on the same server, otherwise IP or hostname', 'bbpress' ); ?></label>
    14711488
    14721489<?php
    … …  
    14811498?>
    14821499
    1483     <input name="_bbp_converter_db_port" id="_bbp_converter_db_port" type="text" value="<?php bbp_form_option( '_bbp_converter_db_port', '3306' ); ?>" class="small-text" />
    1484     <label for="_bbp_converter_db_port"><?php esc_html_e( 'Use default 3306 if unsure', 'bbpress' ); ?></label>
     1500    <input name="_bbp_converter_db_port" id="_bbp_converter_db_port" type="text" class="code" value="<?php bbp_form_option( '_bbp_converter_db_port', '3306' ); ?>" class="small-text" />
     1501    <label for="_bbp_converter_db_port"><?php esc_html_e( 'Use default "3306" if unsure', 'bbpress' ); ?></label>
    14851502
    14861503<?php
    … …  
    14951512?>
    14961513
    1497     <input name="_bbp_converter_db_user" id="_bbp_converter_db_user" type="text" value="<?php bbp_form_option( '_bbp_converter_db_user' ); ?>" class="medium-text" />
    1498     <label for="_bbp_converter_db_user"><?php esc_html_e( 'User for your database connection', 'bbpress' ); ?></label>
     1514    <input name="_bbp_converter_db_user" id="_bbp_converter_db_user" type="text" class="code" value="<?php bbp_form_option( '_bbp_converter_db_user' ); ?>" class="medium-text" />
     1515    <label for="_bbp_converter_db_user"><?php esc_html_e( 'User to acces the database', 'bbpress' ); ?></label>
    14991516
    15001517<?php
    … …  
    15091526?>
    15101527
    1511     <input name="_bbp_converter_db_pass" id="_bbp_converter_db_pass" type="password" value="<?php bbp_form_option( '_bbp_converter_db_pass' ); ?>" class="medium-text" autocomplete="off" />
    1512     <label for="_bbp_converter_db_pass"><?php esc_html_e( 'Password to access the database', 'bbpress' ); ?></label>
     1528    <input name="_bbp_converter_db_pass" id="_bbp_converter_db_pass" type="password" class="code" value="<?php bbp_form_option( '_bbp_converter_db_pass' ); ?>" class="medium-text" autocomplete="off" />
     1529    <label for="_bbp_converter_db_pass"><?php esc_html_e( 'Password of the above database user', 'bbpress' ); ?></label>
    15131530
    15141531<?php
    … …  
    15231540?>
    15241541
    1525     <input name="_bbp_converter_db_name" id="_bbp_converter_db_name" type="text" value="<?php bbp_form_option( '_bbp_converter_db_name' ); ?>" class="medium-text" />
     1542    <input name="_bbp_converter_db_name" id="_bbp_converter_db_name" type="text" class="code" value="<?php bbp_form_option( '_bbp_converter_db_name' ); ?>" class="medium-text" />
    15261543    <label for="_bbp_converter_db_name"><?php esc_html_e( 'Name of the database with your old forum data', 'bbpress' ); ?></label>
    15271544
    … …  
    15501567?>
    15511568
    1552     <input name="_bbp_converter_db_prefix" id="_bbp_converter_db_prefix" type="text" value="<?php bbp_form_option( '_bbp_converter_db_prefix' ); ?>" class="medium-text" />
     1569    <input name="_bbp_converter_db_prefix" id="_bbp_converter_db_prefix" type="text" class="code" value="<?php bbp_form_option( '_bbp_converter_db_prefix' ); ?>" class="medium-text" />
    15531570    <label for="_bbp_converter_db_prefix"><?php esc_html_e( '(If converting from BuddyPress Forums, use "wp_bb_" or your custom prefix)', 'bbpress' ); ?></label>
    15541571
    … …  
    15641581?>
    15651582
    1566     <input name="_bbp_converter_rows" id="_bbp_converter_rows" type="text" value="<?php bbp_form_option( '_bbp_converter_rows', '100' ); ?>" class="small-text" />
     1583    <input name="_bbp_converter_rows" id="_bbp_converter_rows" type="number" min="1" max="5000" value="<?php bbp_form_option( '_bbp_converter_rows', '100' ); ?>" class="small-text" />
    15671584    <label for="_bbp_converter_rows"><?php esc_html_e( 'rows to process at a time', 'bbpress' ); ?></label>
    15681585    <p class="description"><?php esc_html_e( 'Keep this low if you experience out-of-memory issues.', 'bbpress' ); ?></p>
    … …  
    15791596?>
    15801597
    1581     <input name="_bbp_converter_delay_time" id="_bbp_converter_delay_time" type="text" value="<?php bbp_form_option( '_bbp_converter_delay_time', '1' ); ?>" class="small-text" />
     1598    <input name="_bbp_converter_delay_time" id="_bbp_converter_delay_time" type="number" min="1" max="3600" value="<?php bbp_form_option( '_bbp_converter_delay_time', '1' ); ?>" class="small-text" />
    15821599    <label for="_bbp_converter_delay_time"><?php esc_html_e( 'second(s) delay between each group of rows', 'bbpress' ); ?></label>
    15831600    <p class="description"><?php esc_html_e( 'Keep this high to prevent too-many-connection issues.', 'bbpress' ); ?></p>
Note: See TracChangeset for help on using the changeset viewer.