Changeset 6437

Timestamp:

05/27/2017 03:47:49 AM (7 years ago)

Author:

johnjamesjacoby

Message:

General: Tidying from looking into #2876.

Location:

trunk/src/includes

Files:

• common/functions.php (modified) (1 diff)
• replies/template.php (modified) (1 diff)

trunk/src/includes/common/functions.php

@@ -1689 +1689 @@
         $post_status = "'" . implode( "', '", $post_status ) . "'";
         $bbp_db      = bbp_db();
+
+        // Note that we can't use WP_Query here thanks to post_status assumptions
         $query       = $bbp_db->prepare( "SELECT ID FROM {$bbp_db->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = %s ORDER BY ID DESC", $parent_id, $post_type );
         $child_ids   = (array) $bbp_db->get_col( $query );
 
+        // Always cache the results
         wp_cache_set( $cache_id, $child_ids, 'bbpress_posts' );
-    } else {
-        $child_ids = (array) $child_ids;
-    }
+    }
+
+    // Make sure results are INTs
+    $child_ids = wp_parse_id_list( $child_ids );
 
     // Filter and return

trunk/src/includes/replies/template.php

@@ -1829 +1829 @@
         // Reply doesn't have a position so get the raw value
         if ( empty( $reply_position ) ) {
-            $topic_id = ! empty( $topic_id ) ? bbp_get_topic_id( $topic_id ) : bbp_get_reply_topic_id( $reply_id );
+
+            // Get topic ID
+            $topic_id = ! empty( $topic_id )
+                ? bbp_get_topic_id( $topic_id )
+                : bbp_get_reply_topic_id( $reply_id );
 
             // Post is not the topic