Changeset 6415 for trunk/src/includes/admin/converter.php

Timestamp:

05/19/2017 03:25:37 AM (9 years ago)

Author:

johnjamesjacoby

Message:

in_array(): be strict whenever possible.

Use wp_parse_id_list() on certain array values to ensure proper results.

File:

• trunk/src/includes/admin/converter.php (modified) (2 diffs)

trunk/src/includes/admin/converter.php

@@ -981 +981 @@
 
                     // Doing some joining
-                    if ( ! in_array( $item['from_tablename'], $from_tables ) && in_array( $item['join_tablename'], $from_tables ) ) {
+                    if ( ! in_array( $item['from_tablename'], $from_tables, true ) && in_array( $item['join_tablename'], $from_tables, true ) ) {
                         $from_tablename .= ' ' . $item['join_type'] . ' JOIN ' . $this->opdb->prefix . $item['from_tablename'] . ' AS ' . $item['from_tablename'] . ' ' . $item['join_expression'];
                     }
@@ -1041 +1041 @@
                             // This row has a destination that matches one of the
                             // columns in this table.
-                            if ( in_array( $row['to_fieldname'], $tablefield_array ) ) {
+                            if ( in_array( $row['to_fieldname'], $tablefield_array, true ) ) {
 
                                 // Allows us to set default fields.