Skip to:
Content

bbPress.org


Ignore:
Timestamp:
03/20/2017 10:44:00 AM (5 years ago)
Author:
johnjamesjacoby
Message:

Moderation: Allow per-forum moderators to edit topics & replies inside of forums they have moderation control over.

This feature require the following changes:

  • Prefer read_forum capability check over read_private_forums or read_hidden_forums, and include a $forum_id parameter to assist map_meta_cap filters
  • Prefer edit_others_topics|replies over moderate where appropriate, to ensure capability mappings work as intended
  • Introduce bbp_get_public_topic_statuses() to replace several duplicate occurrences of the same array usage (also allow these to be filtered)
  • Introduce bbp_is_topic_public() (not to be confused with bbp_is_topic_published()) to provide parity with bbp_is_forum_public() and also utilize bbp_get_public_topic_statuses() from above
  • Add local caching to bbp_exclude_forum_ids() as a performance optimization to reduce the depth of current_user_can() calls when private & hidden forums are in use
  • Add user_can( 'moderate' ) capability checks to various mappings, to ensure forum moderators can read/edit/delete content inside of the individual forums they are moderators of
  • Use bbp_get_user_id() where appropriate, rather than casting as int
  • Various surrounding code clean-ups

See #2593.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/includes/extend/buddypress/activity.php

    r6372 r6384  
    448448
    449449        // Validate activity data
    450         $user_id  = (int) $topic_author_id;
     450        $user_id  = bbp_get_user_id( $topic_author_id );
    451451        $topic_id = bbp_get_topic_id( $topic_id );
    452452        $forum_id = bbp_get_forum_id( $forum_id );
     
    548548
    549549        // Action based on new status
    550         if ( in_array( $post->post_status, array( bbp_get_public_status_id(), bbp_get_closed_status_id() ) ) ) {
     550        if ( bbp_is_topic_public( $post->ID ) ) {
    551551
    552552            // Validate topic data
     
    597597
    598598        // Validate activity data
    599         $user_id  = (int) $reply_author_id;
     599        $user_id  = bbp_get_user_id( $reply_author_id );
    600600        $reply_id = bbp_get_reply_id( $reply_id );
    601601        $topic_id = bbp_get_topic_id( $topic_id );
Note: See TracChangeset for help on using the changeset viewer.