Changeset 6384 for trunk/src/includes/common/widgets.php

Timestamp:

03/20/2017 10:44:00 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Moderation: Allow per-forum moderators to edit topics & replies inside of forums they have moderation control over.

This feature require the following changes:

• Prefer read_forum capability check over read_private_forums or read_hidden_forums, and include a $forum_id parameter to assist map_meta_cap filters
• Prefer edit_others_topics|replies over moderate where appropriate, to ensure capability mappings work as intended
• Introduce bbp_get_public_topic_statuses() to replace several duplicate occurrences of the same array usage (also allow these to be filtered)
• Introduce bbp_is_topic_public() (not to be confused with bbp_is_topic_published()) to provide parity with bbp_is_forum_public() and also utilize bbp_get_public_topic_statuses() from above
• Add local caching to bbp_exclude_forum_ids() as a performance optimization to reduce the depth of current_user_can() calls when private & hidden forums are in use
• Add user_can( 'moderate' ) capability checks to various mappings, to ensure forum moderators can read/edit/delete content inside of the individual forums they are moderators of
• Use bbp_get_user_id() where appropriate, rather than casting as int
• Various surrounding code clean-ups

See #2593.

File:

• trunk/src/includes/common/widgets.php (modified) (4 diffs)

trunk/src/includes/common/widgets.php

@@ -746 +746 @@
                     'post_parent'         => $settings['parent_forum'],
                     'posts_per_page'      => (int) $settings['max_shown'],
-                    'post_status'         => array( bbp_get_public_status_id(), bbp_get_closed_status_id() ),
+                    'post_status'         => bbp_get_public_topic_statuses(),
                     'ignore_sticky_posts' => true,
                     'no_found_rows'       => true,
@@ -762 +762 @@
                     'post_parent'         => $settings['parent_forum'],
                     'posts_per_page'      => (int) $settings['max_shown'],
-                    'post_status'         => array( bbp_get_public_status_id(), bbp_get_closed_status_id() ),
+                    'post_status'         => bbp_get_public_topic_statuses(),
                     'ignore_sticky_posts' => true,
                     'no_found_rows'       => true,
@@ -779 +779 @@
                     'post_parent'         => $settings['parent_forum'],
                     'posts_per_page'      => (int) $settings['max_shown'],
-                    'post_status'         => array( bbp_get_public_status_id(), bbp_get_closed_status_id() ),
+                    'post_status'         => bbp_get_public_topic_statuses(),
                     'ignore_sticky_posts' => true,
                     'no_found_rows'       => true,
@@ -1131 +1131 @@
         $widget_query = new WP_Query( array(
             'post_type'           => bbp_get_reply_post_type(),
-            'post_status'         => array( bbp_get_public_status_id(), bbp_get_closed_status_id() ),
+            'post_status'         => bbp_get_public_topic_statuses(),
             'posts_per_page'      => (int) $settings['max_shown'],
             'ignore_sticky_posts' => true,