Changeset 6353 for trunk/src/includes/core/functions.php

Timestamp:

03/03/2017 03:47:24 AM (8 years ago)

Author:

johnjamesjacoby

Message:

Core: General core function clean-up.

Mostly odds & ends, formatting, type-casting, etc...

File:

• trunk/src/includes/core/functions.php (modified) (13 diffs)

trunk/src/includes/core/functions.php

@@ -79 +79 @@
 
 /**
- * Update a posts' forum meta ID
+ * Update the forum meta ID of a post
  *
  * @since 2.0.0 bbPress (r3181)
@@ -86 +86 @@
  * @param int $forum_id The forum
  */
-function bbp_update_forum_id( $post_id, $forum_id ) {
+function bbp_update_forum_id( $post_id = 0, $forum_id = 0 ) {
 
     // Allow the forum ID to be updated 'just in time' before save
@@ -98 +98 @@
 
 /**
- * Update a posts' topic meta ID
+ * Update the topic meta ID of a post
  *
  * @since 2.0.0 bbPress (r3181)
@@ -105 +105 @@
  * @param int $topic_id The topic
  */
-function bbp_update_topic_id( $post_id, $topic_id ) {
+function bbp_update_topic_id( $post_id = 0, $topic_id = 0 ) {
 
     // Allow the topic ID to be updated 'just in time' before save
@@ -117 +117 @@
 
 /**
- * Update a posts' reply meta ID
+ * Update the reply meta ID of a post
  *
  * @since 2.0.0 bbPress (r3181)
@@ -124 +124 @@
  * @param int $reply_id The reply
  */
-function bbp_update_reply_id( $post_id, $reply_id ) {
+function bbp_update_reply_id( $post_id = 0, $reply_id = 0 ) {
 
     // Allow the reply ID to be updated 'just in time' before save
@@ -136 +136 @@
 
 /**
- * Update a posts' reply-to meta ID
+ * Update the reply-to meta ID of a post
  *
  * @since 2.6.0 bbPress (r5735)
@@ -143 +143 @@
  * @param int $reply_id The reply ID
  */
-function bbp_update_reply_to_id( $post_id, $reply_id ) {
+function bbp_update_reply_to_id( $post_id = 0, $reply_id = 0 ) {
 
     // Allow the reply ID to be updated 'just in time' before save
@@ -238 +238 @@
 
 /**
- * Run the view's query
+ * Run the query of a topic-view
  *
  * @since 2.0.0 bbPress (r2789)
@@ -252 +252 @@
 function bbp_view_query( $view = '', $new_args = '' ) {
 
+    // Get view, or bail
     $view = bbp_get_view_id( $view );
     if ( empty( $view ) ) {
@@ -268 +269 @@
 
 /**
- * Return the view's query arguments
+ * Return the query arguments of a topic-view
  *
  * @since 2.0.0 bbPress (r2789)
@@ -276 +277 @@
  * @return array Query arguments
  */
-function bbp_get_view_query_args( $view ) {
+function bbp_get_view_query_args( $view = '' ) {
+    $bbp    = bbpress();
     $view   = bbp_get_view_id( $view );
-    $retval = ! empty( $view )
-        ? bbpress()->views[ $view ]['query']
+    $retval = ! empty( $view ) && ! empty( $bbp->views[ $view ] )
+        ? $bbp->views[ $view ]['query']
         : false;
 
@@ -314 +316 @@
  */
 function bbp_has_errors() {
-    $has_errors = bbpress()->errors->get_error_codes() ? true : false;
-
-    return apply_filters( 'bbp_has_errors', $has_errors, bbpress()->errors );
+    $has_errors = bbpress()->errors->get_error_codes()
+        ? true
+        : false;
+
+    return (bool) apply_filters( 'bbp_has_errors', $has_errors, bbpress()->errors );
 }