Changeset 6218

Timestamp:

01/12/2017 07:07:16 AM (5 years ago)

Author:

johnjamesjacoby

Message:

Users: Remove post__in queries from favs/subs template loops.

This is only recently possible thanks to postmeta storage, and should result in a not-insignificant performance boost for those user profile pages.

See #2959.

File:

• trunk/src/includes/users/functions.php (modified) (6 diffs)

trunk/src/includes/users/functions.php

@@ -288 +288 @@
  *
  * @param int $user_id Optional. User id
- * @uses bbp_get_user_favorites_topic_ids() To get the user's favorites
  * @uses bbp_has_topics() To get the topics
  * @uses apply_filters() Calls 'bbp_get_user_favorites' with the topic query and
@@ -295 +294 @@
  */
 function bbp_get_user_favorites( $user_id = 0 ) {
-    $user_id   = bbp_get_user_id( $user_id );
-    $favorites = bbp_get_user_favorites_topic_ids( $user_id );
-    $query     = ! empty( $favorites )
-        ? bbp_has_topics( array( 'post__in' => $favorites ) )
-        : false;
-
-    return apply_filters( 'bbp_get_user_favorites', $query, $user_id, $favorites );
+    $user_id = bbp_get_user_id( $user_id );
+    $query   = bbp_has_topics( array(
+        'meta_query' => array(
+            array(
+                'key'     => '_bbp_favorite',
+                'value'   => $user_id,
+                'compare' => 'NUMERIC'
+            )
+        )
+    ) );
+
+    return apply_filters( 'bbp_get_user_favorites', $query, $user_id );
 }
 
@@ -612 +616 @@
  *
  * @param int $user_id Optional. User id
- * @uses bbp_get_user_subscribed_topic_ids() To get the user's subscriptions
  * @uses bbp_has_topics() To get the topics
  * @uses apply_filters() Calls 'bbp_get_user_subscriptions' with the topic query
@@ -619 +622 @@
  */
 function bbp_get_user_topic_subscriptions( $user_id = 0 ) {
-
-    // Default to the displayed user
-    $user_id       = bbp_get_user_id( $user_id );
-    $subscriptions = bbp_get_user_subscribed_topic_ids( $user_id );
-
-    // If user has subscriptions, load them
-    if ( ! empty( $subscriptions ) ) {
-        $query = bbp_has_topics( array( 'post__in' => $subscriptions ) );
-    } else {
-        $query = false;
-    }
+    $user_id = bbp_get_user_id( $user_id );
+    $query   = bbp_has_topics( array(
+        'meta_query' => array(
+            array(
+                'key'     => '_bbp_subscription',
+                'value'   => $user_id,
+                'compare' => 'NUMERIC'
+            )
+        )
+    ) );
 
     return apply_filters( 'bbp_get_user_topic_subscriptions', $query, $user_id );
@@ -640 +642 @@
  *
  * @param int $user_id Optional. User id
- * @uses bbp_get_user_subscribed_forum_ids() To get the user's subscriptions
  * @uses bbp_has_forums() To get the forums
  * @uses apply_filters() Calls 'bbp_get_user_forum_subscriptions' with the forum
@@ -647 +648 @@
  */
 function bbp_get_user_forum_subscriptions( $user_id = 0 ) {
-
-    // Default to the displayed user
-    $user_id       = bbp_get_user_id( $user_id );
-    $subscriptions = bbp_get_user_subscribed_forum_ids( $user_id );
-
-    // If user has subscriptions, load them
-    if ( ! empty( $subscriptions ) ) {
-        $query = bbp_has_forums( array( 'post__in' => $subscriptions ) );
-    } else {
-        $query = false;
-    }
+    $user_id = bbp_get_user_id( $user_id );
+    $query   = bbp_has_forums( array(
+        'meta_query' => array(
+            array(
+                'key'     => '_bbp_subscription',
+                'value'   => $user_id,
+                'compare' => 'NUMERIC'
+            )
+        )
+    ) );
 
     return apply_filters( 'bbp_get_user_forum_subscriptions', $query, $user_id );