Changeset 6217

Timestamp:

01/12/2017 07:04:27 AM (9 years ago)

Author:

netweb

Message:

Unit Tests: Don't run BuddyPress PHPUnit tests on PHP 5.2.x

Previously r6204 attempted to skip BuddyPress tests if the PHP version was less than 5.3.0, this didn't work as intended as BuddyPress was still being loaded, the change would have only skipped tests rather than completely excluding the BuddyPress PHPUnit test suite from running on PHP versions less than 5.3.0.

This changeset reverts r6204 and separates the grunt test tasks into individual WordPress and BuddyPress PHPUnit Grunt tasks, this gives us the ability to explicitly exclude BuddyPress PHPUnit test suite from running on PHP 5.2.

See also ​https://bpdevel.wordpress.com/2016/07/21/php-5-2-bp-2-8-and-php-support-guidelines/

Fixes #3037.

Location:

trunk

Files:

• .travis.yml (modified) (1 diff)
• Gruntfile.js (modified) (2 diffs)
• tests/phpunit/buddypress.xml (modified) (1 diff)

trunk/.travis.yml

@@ -90 +90 @@
 script:
   - grunt travis
+  - if [ "$TRAVIS_PHP_VERSION" != "5.2" ]; then grunt test:buddypress; fi
 
 notifications:

trunk/Gruntfile.js

@@ -409 +409 @@
 
     // PHPUnit test task.
-    grunt.registerTask( 'test', 'Run all PHPUnit test tasks.', [ 'phpunit' ] );
+    grunt.registerTask( 'test:buddypress', 'Run the BuddyPress PHPUnit test tasks.', [ 'phpunit:buddypress' ] );
+    grunt.registerTask( 'test:wordpress', 'Run the single and multisite WordPress PHPUnit test tasks.', [ 'phpunit:default', 'phpunit:multisite' ] );
+
+
+
 
     // JavaScript test task.
@@ -415 +419 @@
 
     // Travis CI Task
-    grunt.registerTask( 'travis', [ 'jsvalidate:src', 'jshint', 'checktextdomain', 'test' ] );
+    grunt.registerTask( 'travis', [ 'jsvalidate:src', 'jshint', 'checktextdomain', 'test:wordpress' ] );
 
     // Patch task.

trunk/tests/phpunit/buddypress.xml

@@ -12 +12 @@
     <testsuites>
         <testsuite>
-            <directory suffix=".php" phpVersion="5.3.0" phpVersionOperator=">=">./testcases/</directory>
+            <directory suffix=".php">./testcases/</directory>
         </testsuite>
     </testsuites>