Changeset 6205

Timestamp:

01/03/2017 07:25:44 PM (6 years ago)

Author:

xknown

Message:

branch 1.1: Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.
See #3033

File:

• branches/1.1/bb-includes/functions.bb-deprecated.php (modified) (1 diff)

branches/1.1/bb-includes/functions.bb-deprecated.php

@@ -469 +469 @@
     bb_log_deprecated('function', __FUNCTION__, 'bb_tag_heat_map (with variations to arguments)');
     $defaults = array( 'smallest' => 8, 'largest' => 22, 'unit' => 'pt', 'limit' => 45, 'format' => 'flat' );
+    $_args = func_get_args();
     $args = wp_parse_args( $args, $defaults );
 
     if ( 1 < $fn = func_num_args() ) : // For back compat
-        $args['smallest'] = func_get_arg(0);
-        $args['largest']  = func_get_arg(1);
-        $args['unit']     = 2 < $fn ? func_get_arg(2) : $unit;
-        $args['limit']    = 3 < $fn ? func_get_arg(3) : $limit;
+        $args['smallest'] = $_args[0];
+        $args['largest']  = $_args[1];
+        $args['unit']     = 2 < $fn ? $_args[2] : $unit;
+        $args['limit']    = 3 < $fn ? $_args[3] : $limit;
     endif;