Changeset 6191 for trunk/src/includes/admin/converters/e107v1.php

Timestamp:

12/28/2016 04:24:52 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Audit direct query and prepare() usages, and more tightly adhere to best practices.

• No quotes around directives
• Avoid concatenation, prefer variable parsing in double-quoted strings
• Covers converters, helper functions, and tools

File:

• trunk/src/includes/admin/converters/e107v1.php (modified) (1 diff)

trunk/src/includes/admin/converters/e107v1.php

@@ -577 +577 @@
         if ( ! isset( $this->map_userid[ $field ] ) ) {
             if ( ! empty( $this->sync_table ) ) {
-                $row = $this->wpdb->get_row( $this->wpdb->prepare( 'SELECT value_id, meta_value FROM ' . $this->sync_table_name . ' WHERE meta_key = "_bbp_old_user_id" AND meta_value = "%s" LIMIT 1', $field ) );
+                $row = $this->wpdb->get_row( $this->wpdb->prepare( "SELECT value_id, meta_value FROM {$this->sync_table_name} WHERE meta_key = %s AND meta_value = %s LIMIT 1", '_bbp_old_user_id', $field ) );
             } else {
-                $row = $this->wpdb->get_row( $this->wpdb->prepare( 'SELECT user_id AS value_id FROM ' . $this->wpdb->usermeta . ' WHERE meta_key = "_bbp_old_user_id" AND meta_value = "%s" LIMIT 1', $field ) );
+                $row = $this->wpdb->get_row( $this->wpdb->prepare( "SELECT user_id AS value_id FROM {$this->wpdb->usermeta} WHERE meta_key = %s AND meta_value = %s LIMIT 1", '_bbp_old_user_id', $field ) );
             }