Skip to:
Content

bbPress.org


Ignore:
Timestamp:
12/27/2016 10:45:16 PM (9 years ago)
Author:
johnjamesjacoby
Message:

Admin: Implement new loading sequence for major admin components.

  • Introduce new bbp_current_screen sub-action
  • Hook forums/topics/replies into bbp_current_screen
  • Remove various bail() methods, which were fragile and terrible anyways
  • Revert r6178, thanks to order-of-operation issues with get_current_screen()
  • Remove Comments & Discussion metaboxes if comments is not explicitly supported

See #2959.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/includes/admin/actions.php

    r5951 r6186  
    4343add_action( 'admin_head',              'bbp_admin_head'                    );
    4444add_action( 'admin_notices',           'bbp_admin_notices'                 );
     45add_action( 'menu_order',              'bbp_admin_menu_order'              );
    4546add_action( 'custom_menu_order',       'bbp_admin_custom_menu_order'       );
    46 add_action( 'menu_order',              'bbp_admin_menu_order'              );
     47add_action( 'current_screen',          'bbp_current_screen'                );
    4748add_action( 'wpmu_new_blog',           'bbp_new_site',               10, 6 );
    4849
    4950// Hook on to admin_init
    50 add_action( 'bbp_admin_init', 'bbp_admin_forums'                );
    51 add_action( 'bbp_admin_init', 'bbp_admin_topics'                );
    52 add_action( 'bbp_admin_init', 'bbp_admin_replies'               );
    5351add_action( 'bbp_admin_init', 'bbp_setup_updater',          999 );
    5452add_action( 'bbp_admin_init', 'bbp_register_importers'          );
     
    5654add_action( 'bbp_admin_init', 'bbp_register_admin_settings'     );
    5755add_action( 'bbp_admin_init', 'bbp_do_activation_redirect', 1   );
     56
     57// Hook on to current_screen
     58add_action( 'bbp_current_screen', 'bbp_admin_forums'  );
     59add_action( 'bbp_current_screen', 'bbp_admin_topics'  );
     60add_action( 'bbp_current_screen', 'bbp_admin_replies' );
    5861
    5962// Initialize the admin area
     
    261264    do_action( 'bbp_register_admin_settings' );
    262265}
     266
     267/**
     268 * Dedicated action to hook into the current screen
     269 *
     270 * @since 2.6.0 bbPress (r6185)
     271 *
     272 * @param WP_Screen $current_screen
     273 * @uses do_action() Calls 'bbp_current_screen'
     274 */
     275function bbp_current_screen( $current_screen = '' ) {
     276    do_action( 'bbp_current_screen', $current_screen );
     277}
Note: See TracChangeset for help on using the changeset viewer.