Changeset 6156 for branches/1.1/bb-includes/functions.bb-topics.php

Timestamp:

12/09/2016 02:08:07 PM (10 years ago)

Author:

xknown

Message:

Fix PHP 7 compat issues w.r.t. the use of func_get_arg().

func_get_arg() returns the current (modified) value of the given argument. Let's make sure the code behaves the same.

See #3033

File:

• branches/1.1/bb-includes/functions.bb-topics.php (modified) (3 diffs)

branches/1.1/bb-includes/functions.bb-topics.php

@@ -60 +60 @@
 
 function get_latest_topics( $args = null ) {
+        $_args = func_get_args();
         $defaults = array( 'forum' => false, 'page' => 1, 'exclude' => false, 'number' => false );
         if ( is_numeric( $args ) )
@@ -66 +67 @@
                 $args = wp_parse_args( $args ); // Make sure it's an array
         if ( 1 < func_num_args() )
-                $args['page'] = func_get_arg(1);
+                $args['page'] = $_args[1];
         if ( 2 < func_num_args() )
-                $args['exclude'] = func_get_arg(2);
+                $args['exclude'] = $_args[2];
 
         $args = wp_parse_args( $args, $defaults );
@@ -437 +438 @@
 
 function get_thread( $topic_id, $args = null ) {
+        $_args = func_get_args();
         $defaults = array( 'page' => 1, 'order' => 'ASC' );
         if ( is_numeric( $args ) )
                 $args = array( 'page' => $args );
-        if ( @func_get_arg(2) )
+        if ( @$_args[2] )
                 $defaults['order'] = 'DESC';