Changeset 6130

Timestamp:

11/30/2016 02:23:26 PM (8 years ago)

Author:

johnjamesjacoby

Message:

Converter: Set maximum key index length to 191.

Fixes bug where table would not be created because utf8mb4 character sets do not have room for that many bytes.

(Also, pass query as an array into dbDelta() so it doesn't need to do the work for us anymore.)

See #3026. (2.5 branch, for 2.5.12)

File:

• branches/2.5/includes/admin/converter.php (modified) (1 diff)

branches/2.5/includes/admin/converter.php

@@ -553 +553 @@
         /** Translator ****************************************************/
 
-        $sql = "CREATE TABLE {$table_name} (
+        $sql = array();
+        $max_index_length = 191;
+
+        $sql[] = "CREATE TABLE {$table_name} (
                     meta_id mediumint(8) unsigned not null auto_increment,
                     value_type varchar(25) null,
                     value_id bigint(20) unsigned not null default '0',
-                    meta_key varchar(25) null,
-                    meta_value varchar(25) null,
-                PRIMARY KEY  (meta_id),
+                    meta_key varchar(255) null,
+                    meta_value varchar(255) null,
+                PRIMARY KEY (meta_id),
                     KEY value_id (value_id),
-                    KEY meta_join (meta_key, meta_value) ) {$charset_collate};";
+                    KEY meta_join (meta_key({$max_index_length}), meta_value({$max_index_length}))
+                ) {$charset_collate};";
 
         dbDelta( $sql );