Changeset 6112

Timestamp:

11/02/2016 09:06:30 AM (4 years ago)

Author:

netweb

Message:

Theme Compatibility: Parameter $in_footer in bbp_enqueue_script() should be boolean.

This changeset updates copy-pasta introduced in [5181], bbp_enqueue_script() is a wrapper for wp_enqueue_script(), $in_footer boolean parameter introduced in ​wp:changeset:10367. Whether on purpose, or inadvertently, our scripts where being added in the footer, this commit explicitly maintains this behavior.

Props thebrandonallen.
Fixes #3013.

Location:

trunk/src

Files:

• includes/core/template-functions.php (modified) (1 diff)
• templates/default/bbpress-functions.php (modified) (1 diff)

trunk/src/includes/core/template-functions.php

@@ -197 +197 @@
  * @return string The script filename if one is located.
  */
-function bbp_enqueue_script( $handle = '', $file = '', $deps = array(), $ver = false, $in_footer = 'all' ) {
+function bbp_enqueue_script( $handle = '', $file = '', $deps = array(), $ver = false, $in_footer = false ) {
 
     // No file found yet

trunk/src/templates/default/bbpress-functions.php

@@ -212 +212 @@
         // Enqueue the scripts
         foreach ( $scripts as $handle => $attributes ) {
-            bbp_enqueue_script( $handle, $attributes['file'], $attributes['dependencies'], $this->version, 'screen' );
+            bbp_enqueue_script( $handle, $attributes['file'], $attributes['dependencies'], $this->version, true );
         }
     }