Changeset 6110

Timestamp:

11/02/2016 05:22:08 AM (9 years ago)

Author:

netweb

Message:

Tests: Use assertEqualSets() instead of assertEquals() in favorites and subscriptions tests.

This changeset improves array comparisons where arrays may not be in the same order.

See #2959.

Location:

trunk/tests/phpunit/testcases/users/functions

Files:

• favorites.php (modified) (9 diffs)
• subscriptions.php (modified) (8 diffs)

trunk/tests/phpunit/testcases/users/functions/favorites.php

@@ -24 +24 @@
         $favoriters = bbp_get_topic_favoriters( $t );
 
-        $this->assertEquals( $expected, $favoriters );
+        $this->assertEqualSets( $expected, $favoriters );
 
         // Add topic favorites.
@@ -32 +32 @@
         $favoriters = bbp_get_topic_favoriters( $t );
 
-        $this->assertEquals( $expected, $favoriters );
+        $this->assertEqualSets( $expected, $favoriters );
 
         // Remove user favorite.
@@ -40 +40 @@
         $favoriters = bbp_get_topic_favoriters( $t );
 
-        $this->assertEquals( $expected, $favoriters );
+        $this->assertEqualSets( $expected, $favoriters );
     }
 
@@ -83 +83 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[1], $t[2] ), $favorites );
+        $this->assertEqualSets( array( $t[0], $t[1], $t[2] ), $favorites );
 
         // Remove user favorite.
@@ -90 +90 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[2] ), $favorites );
+        $this->assertEqualSets( array( $t[0], $t[2] ), $favorites );
     }
 
@@ -127 +127 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[1] ), $favorites );
+        $this->assertEqualSets( array( $t[0], $t[1] ), $favorites );
 
         // Add user favorite.
@@ -134 +134 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[1], $t[2] ), $favorites );
+        $this->assertEqualSets( array( $t[0], $t[1], $t[2] ), $favorites );
     }
 
@@ -154 +154 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[1] ), $favorites );
+        $this->assertEqualSets( array( $t[0], $t[1] ), $favorites );
 
         // Remove user favorite.
@@ -161 +161 @@
         $favorites = bbp_get_user_favorites_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0] ), $favorites );
+        $this->assertEqualSets( array( $t[0] ), $favorites );
     }
 

trunk/tests/phpunit/testcases/users/functions/subscriptions.php

@@ -24 +24 @@
         $subscribers = bbp_get_forum_subscribers( $f[0] );
 
-        $this->assertEquals( array( $u[0], $u[1], $u[2] ), $subscribers );
+        $this->assertEqualSets( array( $u[0], $u[1], $u[2] ), $subscribers );
 
         // Add forum subscriptions.
@@ -32 +32 @@
         $subscribers = bbp_get_forum_subscribers( $f[1] );
 
-        $this->assertEquals( array( $u[0], $u[2] ), $subscribers );
+        $this->assertEqualSets( array( $u[0], $u[2] ), $subscribers );
     }
 
@@ -49 +49 @@
         $subscribers = bbp_get_topic_subscribers( $t[0] );
 
-        $this->assertEquals( array( $u[0], $u[1], $u[2] ), $subscribers );
+        $this->assertEqualSets( array( $u[0], $u[1], $u[2] ), $subscribers );
 
         // Add topic subscriptions.
@@ -57 +57 @@
         $subscribers = bbp_get_topic_subscribers( $t[1] );
 
-        $this->assertEquals( array( $u[0], $u[2] ), $subscribers );
+        $this->assertEqualSets( array( $u[0], $u[2] ), $subscribers );
     }
 
@@ -153 +153 @@
         $subscriptions = bbp_get_user_subscribed_forum_ids( $u );
 
-        $this->assertEquals( array( $f[0], $f[1], $f[2] ), $subscriptions );
+        $this->assertEqualSets( array( $f[0], $f[1], $f[2] ), $subscriptions );
 
         // Remove forum subscription.
@@ -160 +160 @@
         $subscriptions = bbp_get_user_subscribed_forum_ids( $u );
 
-        $this->assertEquals( array( $f[0], $f[2] ), $subscriptions );
+        $this->assertEqualSets( array( $f[0], $f[2] ), $subscriptions );
     }
 
@@ -177 +177 @@
         $subscriptions = bbp_get_user_subscribed_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[1], $t[2] ), $subscriptions );
+        $this->assertEqualSets( array( $t[0], $t[1], $t[2] ), $subscriptions );
 
         // Remove topic subscription.
@@ -184 +184 @@
         $subscriptions = bbp_get_user_subscribed_topic_ids( $u );
 
-        $this->assertEquals( array( $t[0], $t[2] ), $subscriptions );
+        $this->assertEqualSets( array( $t[0], $t[2] ), $subscriptions );
     }