Changeset 6100

Timestamp:

09/21/2016 07:27:28 AM (8 years ago)

Author:

netweb

Message:

Build Tools: Switch stylelint Grunt task from grunt postcss:lint to grunt stylelint

This changeset switches the stylelint task from using the grunt-postcss to grunt-stylelint NPM module. This new Grunt module supports stylelint's native formatters and allows for improved task error reporting. This change also splits the CSS and SCSS lint tasks in preparation for a future stylelint-config-wordpress SCSS update.

See also: ​https://github.com/wikimedia/grunt-stylelint

Props netweb.
See #2924.

Location:

trunk

Files:

• Gruntfile.js (modified) (4 diffs)
• package.json (modified) (1 diff)

trunk/Gruntfile.js

@@ -47 +47 @@
 
         // PostCSS
-        autoprefixer = require('autoprefixer'),
-        stylelint    = require('stylelint'),
-        reporter     = require('postcss-reporter');
+        autoprefixer = require('autoprefixer');
 
     // Load tasks.
@@ -268 +266 @@
                 dest: BUILD_DIR,
                 src: [ 'includes/admin/styles/*/colors.css' ]
-            },
-            lint: {
-                options: {
-                    syntax: require('postcss-scss'),
-                    processors: [
-                        stylelint(),
-                        reporter({
-                            clearMessages: true,
-                            throwError: true
-                            }
-                        )
-                    ]
-                },
-                expand: true,
-                cwd: SOURCE_DIR,
-                dest: SOURCE_DIR,
-                src: [ [ BBP_LTR_CSS ], 'includes/admin/styles/*/colors.scss' ]
             }
         },
@@ -323 +304 @@
             }
         },
+        stylelint: {
+            css: {
+                options: {
+                    configFile: '.stylelintrc',
+                    format: 'css'
+                },
+                expand: true,
+                cwd: SOURCE_DIR,
+                src: BBP_LTR_CSS
+            },
+            scss: {
+                options: {
+                    configFile: '.stylelintrc',
+                    format: 'scss'
+                },
+                expand: true,
+                cwd: SOURCE_DIR,
+                src: [ 'includes/admin/styles/*/colors.scss' ]
+            }
+        },
         uglify: {
             core: {
@@ -393 +394 @@
 
     // Build tasks.
-    grunt.registerTask( 'src',     [ 'checkDependencies', 'jsvalidate:src', 'jshint', 'postcss:lint' ] );
+    grunt.registerTask( 'src',     [ 'checkDependencies', 'jsvalidate:src', 'jshint', 'stylelint' ] );
     grunt.registerTask( 'commit',  [ 'src', 'checktextdomain' ] );
     grunt.registerTask( 'build',   [ 'commit', 'clean:all', 'copy:files', 'postcss:core', 'colors', 'rtlcss:core', 'cssmin:ltr', 'cssmin:rtl', 'uglify:core', 'jsvalidate:build', 'makepot' ] );

trunk/package.json

@@ -23 +23 @@
     "grunt-rtlcss": "~2.0.1",
     "grunt-sass": "~1.2.0",
+    "grunt-stylelint": "^0.6.0",
     "grunt-wp-i18n": "~0.5.2",
     "matchdep": "~1.0.1",
-    "postcss-reporter": "~1.3.3",
-    "postcss-scss": "~0.1.7",
+    "postcss-scss": "~0.3.0",
     "stylelint": "^7.2.0"
   },