Changeset 6056 for trunk/src/bbpress.php

Timestamp:

06/05/2016 06:27:54 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Moderators: Refactor per-forum moderators to use meta-data instead of mocked taxonomy terms.

If the future of Forums is a taxonomy (vs. a custom post-type) then a per-forum Moderator taxonomy for a Forum taxonomy won't work very well, for a few reasons:

• Scalability
• Taxonomies for taxonomies is a bit more inception than should be required for this simple feature
• Forum moderators do not require much of what taxonomy objects provide (permalinks, visibility, metadata, etc...)
• User taxonomy terms matching nicenames works okay for something like Automattic's P2 theme, but bbPress requires a user ID based solution to avoid data synchronization issues between nicenames & term slugs

So... the future of per-forum per-user capability mappings is in meta-data using map_meta_cap.

This commit:

• Removes the forum_mod taxonomy and surrounding code additions introduced in the first pass in r5834
• Renames forum_mod functions to forum_moderator to be more explicit
• Adds CRUD wrapper functions for per-forum moderator meta data
• Adds administrative interfaces for assigning moderators to forums for wp-admin and forum edit pages
• Adds helper functions for getting user nicenames & IDs

Note that this feature has now been refactored to no longer be forum specific (I.E. object agnostic) -- it's possible for any user access to be mapped based on the object type using any meta-data key. While this is currently useful for per-forum moderators, it may be user for per-topic blocking, per-topic-tag moderation, etc...

See #459.

File:

• trunk/src/bbpress.php (modified) (4 diffs)

trunk/src/bbpress.php

@@ -227 +227 @@
         // Post type identifiers
         $this->forum_post_type   = apply_filters( 'bbp_forum_post_type',  'forum'     );
-        $this->forum_mod_tax_id  = apply_filters( 'bbp_forum_mod_tax_id', 'forum-mod' );
         $this->topic_post_type   = apply_filters( 'bbp_topic_post_type',  'topic'     );
         $this->topic_tag_tax_id  = apply_filters( 'bbp_topic_tag_tax_id', 'topic-tag' );
@@ -663 +662 @@
      *
      * @since 2.0.0 bbPress (r2464) Added bbp_get_topic_tag_tax_id() taxonomy
-     * @since 2.6.0 bbPress (r5834) Added bbp_get_forum_mod_tax_id() taxonomy
      *
      * @uses register_taxonomy() To register the taxonomy
@@ -673 +671 @@
      * @uses current_user_can() To check if the current user can edit/delete tags
      * @uses bbp_get_forum_post_type() To get the forum post type
-     * @uses bbp_get_forum_mod_tax_labels() To get the forum moderator taxonomy label
-     * @uses bbp_get_forum_mod_caps() To check the forum moderator capabilities
-     * @uses bbp_allow_forum_mods() To check if forum moderators are allowed
      * @uses current_user_can() To check if the current user can edit/delete forums
      */
@@ -697 +692 @@
             )
         ) );
-
-        // Register the forum-mod taxonomy.
-        register_taxonomy(
-            bbp_get_forum_mod_tax_id(),
-            bbp_get_forum_post_type(),
-            apply_filters( 'bbp_register_forum_moderator_taxonomy', array(
-                'labels'                => bbp_get_forum_mod_tax_labels(),
-                'capabilities'          => bbp_get_forum_mod_caps(),
-                'update_count_callback' => '_update_post_term_count',
-                'query_var'             => false,
-                'show_tagcloud'         => true,
-                'hierarchical'          => false,
-                'show_in_menu'          => true,
-                'show_in_nav_menus'     => false,
-                'public'                => false,
-                'show_ui'               => bbp_allow_forum_mods() && current_user_can( 'bbp_forum_mods_admin' ),
-            )
-        ) );
     }