Changeset 6036 for trunk/src/includes/replies/functions.php

Timestamp:

05/30/2016 10:28:36 AM (7 years ago)

Author:

netweb

Message:

General Performance: Introduce increase/decrease helper count functions

Previously when a new topic or reply was created, a bunch of queries to recalculate the topic and reply counts for topics and forums were ran. Now these have been replaced with more efficient increase/decrease helper functions to get the current value and just "bump" the count based on the action (new topic-reply/split-topic/move-topic/spam-trash-topic/etc...)

Props thebrandonallen, tharsheblows, netweb
See #1799

File:

• trunk/src/includes/replies/functions.php (modified) (3 diffs)

trunk/src/includes/replies/functions.php

@@ -66 +66 @@
     bbp_update_reply( $reply_id, $reply_meta['topic_id'], $reply_meta['forum_id'], array(), $reply_data['post_author'], false, $reply_meta['reply_to'] );
 
+    /**
+     * Fires after reply has been inserted via `bbp_insert_reply`.
+     *
+     * @since 2.6.0 bbPress (r6036)
+     *
+     * @param int $reply_id               The reply id.
+     * @param int $reply_meta['topic_id'] The reply topic meta.
+     * @param int $reply_meta['forum_id'] The reply forum meta.
+     */
+    do_action( 'bbp_insert_reply', (int) $reply_id, (int) $reply_meta['topic_id'], (int) $reply_meta['forum_id'] );
+
     // Return new reply ID
     return $reply_id;
+}
+
+/**
+ * Update counts after a reply is inserted via `bbp_insert_reply`.
+ *
+ * @since 2.6.0 bbPress (r6036)
+ *
+ * @param int $reply_id The reply id.
+ * @param int $topic_id The topic id.
+ * @param int $forum_id The forum id.
+ *
+ * @uses bbp_get_reply_status() To get the reply status
+ * @uses bbp_get_public_status_id() To get the public status id
+ * @uses bbp_increase_topic_reply_count() To bump the topics reply count by 1
+ * @uses bbp_increase_forum_reply_count() To bump the forums reply count by 1
+ * @uses bbp_increase_topic_reply_count_hidden() To bump the topics hidden reply
+ *                                               count by 1
+ *
+ * @return void
+ */
+function bbp_insert_reply_update_counts( $reply_id = 0, $topic_id = 0, $forum_id = 0 ) {
+
+    // If the reply is public, update the forum/topic reply counts.
+    if ( bbp_get_reply_status( $reply_id ) === bbp_get_public_status_id() ) {
+        bbp_increase_topic_reply_count( $topic_id );
+        bbp_increase_forum_reply_count( $forum_id );
+
+    // If the reply isn't public only update the topic reply hidden count.
+    } else {
+        bbp_increase_topic_reply_count_hidden( $topic_id );
+    }
 }
 
@@ -978 +1020 @@
 
                 // Counts
-                bbp_update_topic_voice_count       ( $ancestor );
-                bbp_update_topic_reply_count       ( $ancestor );
-                bbp_update_topic_reply_count_hidden( $ancestor );
+                bbp_update_topic_voice_count( $ancestor );
+
+                // Only update reply count if we're deleting a reply, or in the dashboard.
+                if ( in_array( current_filter(), array( 'bbp_deleted_reply', 'save_post' ), true ) ) {
+                    bbp_update_topic_reply_count(        $ancestor );
+                    bbp_update_topic_reply_count_hidden( $ancestor );
+                }
 
             // Forum meta relating to most recent topic
@@ -1004 +1050 @@
 
                 // Counts
-                bbp_update_forum_reply_count( $ancestor );
+                // Only update reply count if we're deleting a reply, or in the dashboard.
+                if ( in_array( current_filter(), array( 'bbp_deleted_reply', 'save_post' ), true ) ) {
+                    bbp_update_forum_reply_count( $ancestor );
+                }
             }
         }