Changeset 6032 for trunk/src/includes/admin/replies.php

Timestamp:

05/25/2016 01:23:29 AM (9 years ago)

Author:

johnjamesjacoby

Message:

Moderators: pass current forum/topic/reply ID into moderate capability checks, providing additional context about what's being moderated so more targeted decisions can be made.

See #459.

File:

• trunk/src/includes/admin/replies.php (modified) (2 diffs)

trunk/src/includes/admin/replies.php

@@ -716 +716 @@
                     // Alert capable users of reply forum mismatch
                     if ( $reply_forum_id !== $topic_forum_id ) {
-                        if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) {
+                        if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate', $reply_id ) ) {
                             $forum_title .= '<div class="attention">' . esc_html__( '(Mismatch)', 'bbpress' ) . '</div>';
                         }
@@ -851 +851 @@
         }
 
-        // Add Empty Spam button
+        // Add "Empty Spam" button for moderators
         if ( ! empty( $_GET['post_status'] ) && ( bbp_get_spam_status_id() === $_GET['post_status'] ) && current_user_can( 'moderate' ) ) {
             wp_nonce_field( 'bulk-destroy', '_destroy_nonce' );
-            $title = esc_attr__( 'Empty Spam', 'bbpress' );
-            submit_button( $title, 'button-secondary apply', 'delete_all', false );
+            submit_button( 
+                esc_attr__( 'Empty Spam', 'bbpress' ),
+                'button-secondary apply',
+                'delete_all',
+                false
+            );
         }
 
         // Get which forum is selected
-        $selected = ! empty( $_GET['bbp_forum_id'] ) ? $_GET['bbp_forum_id'] : '';
+        $selected = ! empty( $_GET['bbp_forum_id'] )
+            ? (int) $_GET['bbp_forum_id']
+            : 0;
 
         // Show the forums dropdown