Changeset 6027

Timestamp:

05/19/2016 07:42:24 PM (9 years ago)

Author:

johnjamesjacoby

Message:

Statuses, Types, Visibilities: bbp_get_topic_types() usages were missed in r6026.

See #2954.

Location:

trunk/src/includes/topics

Files:

• functions.php (modified) (1 diff)
• template.php (modified) (2 diffs)

trunk/src/includes/topics/functions.php

@@ -753 +753 @@
         /** Stickies **********************************************************/
 
-        if ( ! empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array_keys( bbp_get_topic_types() ) ) ) {
+        // Get the topic types
+        $topic_types = bbp_get_topic_types( $topic_id );
+
+        // Maybe sticky
+        if ( ! empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array_keys( $topic_types ) ) ) {
 
             // What's the caps?

trunk/src/includes/topics/template.php

@@ -3307 +3307 @@
 
                     // Get current topic id
-                    $topic_id = bbp_get_topic_id( $r['topic_id'] );
+                    $r['topic_id'] = bbp_get_topic_id( $r['topic_id'] );
 
                     // Topic is super sticky
-                    if ( bbp_is_topic_super_sticky( $topic_id ) ) {
+                    if ( bbp_is_topic_super_sticky( $r['topic_id'] ) ) {
                         $r['selected'] = 'super';
 
                     // Topic is sticky or normal
                     } else {
-                        $r['selected'] = bbp_is_topic_sticky( $topic_id, false ) ? 'stick' : 'unstick';
+                        $r['selected'] = bbp_is_topic_sticky( $r['topic_id'], false )
+                            ? 'stick'
+                            : 'unstick';
                     }
                 }
@@ -3329 +3331 @@
         <select name="<?php echo esc_attr( $r['select_id'] ); ?>" id="<?php echo esc_attr( $r['select_id'] ); ?>_select" class="<?php echo esc_attr( $r['select_class'] ); ?>"<?php echo $tab; ?>>
 
-            <?php foreach ( bbp_get_topic_types() as $key => $label ) : ?>
+            <?php foreach ( bbp_get_topic_types( $r['topic_id'] ) as $key => $label ) : ?>
 
                 <option value="<?php echo esc_attr( $key ); ?>"<?php selected( $key, $r['selected'] ); ?>><?php echo esc_html( $label ); ?></option>