Skip to:
Content

bbPress.org

Changeset 5868


Ignore:
Timestamp:
07/17/2015 11:49:26 PM (6 years ago)
Author:
johnjamesjacoby
Message:

Strings: prefer — over parenthesis when wrapping "No" style results.

This changeset normalizes the strings used to pick the parent of a forum, topic, and reply. The — may be changed later to improve localization, but for now this provides a good balance of visual separation and familiar UX.

Location:
trunk/src
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/includes/admin/forums.php

    r5835 r5868  
    220220                    '<li>' . __( '<strong>Status</strong> allows you to close a forum to new topics and forums.',                                                                                                                  'bbpress' ) . '</li>' .
    221221                    '<li>' . __( '<strong>Visibility</strong> lets you pick the scope of each forum and what users are allowed to access it.',                                                                                     'bbpress' ) . '</li>' .
    222                     '<li>' . __( '<strong>Parent</strong> dropdown determines the parent forum. Select the forum or category from the dropdown, or leave the default (No Parent) to create the forum at the root of your forums.', 'bbpress' ) . '</li>' .
     222                    '<li>' . __( '<strong>Parent</strong> dropdown determines the parent forum. Select the forum or category from the dropdown, or leave the default "No parent" to create the forum at the root of your forums.', 'bbpress' ) . '</li>' .
    223223                    '<li>' . __( '<strong>Order</strong> allows you to order your forums numerically.',                                                                                                                            'bbpress' ) . '</li>' .
    224224                '</ul>'
  • trunk/src/includes/admin/metaboxes.php

    r5850 r5868  
    357357            'select_id'          => 'parent_id',
    358358            'options_only'       => false,
    359             'show_none'          => __( '&mdash; No parent &mdash;', 'bbpress' ),
     359            'show_none'          => __( '&mdash; No forum &mdash;', 'bbpress' ),
    360360            'disable_categories' => false,
    361361            'disabled'           => ''
     
    511511                'select_id'          => 'bbp_forum_id',
    512512                'options_only'       => false,
    513                 'show_none'          => __( '&mdash; No parent &mdash;', 'bbpress' ),
     513                'show_none'          => __( '&mdash; No reply &mdash;', 'bbpress' ),
    514514                'disable_categories' => current_user_can( 'edit_forums' ),
    515515                'disabled'           => ''
  • trunk/src/includes/admin/topics.php

    r5850 r5868  
    227227                '<p>' . __( 'Select the attributes that your topic should have:', 'bbpress' ) . '</p>' .
    228228                '<ul>' .
    229                     '<li>' . __( '<strong>Forum</strong> dropdown determines the parent forum that the topic belongs to. Select the forum or category from the dropdown, or leave the default (No Forum) to post the topic without an assigned forum.', 'bbpress' ) . '</li>' .
     229                    '<li>' . __( '<strong>Forum</strong> dropdown determines the parent forum that the topic belongs to. Select the forum or category from the dropdown, or leave the default "No forum" to post the topic without an assigned forum.', 'bbpress' ) . '</li>' .
    230230                    '<li>' . __( '<strong>Topic Type</strong> dropdown indicates the sticky status of the topic. Selecting the super sticky option would stick the topic to the front of your forums, i.e. the topic index, sticky option would stick the topic to its respective forum. Selecting normal would not stick the topic anywhere.', 'bbpress' ) . '</li>' .
    231231                '</ul>'
     
    780780
    781781                } else {
    782                     esc_html_e( '(No Forum)', 'bbpress' );
     782                    esc_html_e( '&mdash; No forum &mdash;', 'bbpress' );
    783783                }
    784784
  • trunk/src/includes/common/template.php

    r5829 r5868  
    14101410     *  - tab: Deprecated. Tabindex value. False or integer
    14111411     *  - options_only: Show only <options>? No <select>?
    1412      *  - show_none: Boolean or String __( '(No Forum)', 'bbpress' )
     1412     *  - show_none: Boolean or String __( '&mdash; No Forum &mdash;', 'bbpress' )
    14131413     *  - disable_categories: Disable forum categories and closed forums?
    14141414     *                         Defaults to true. Only for forums and when
  • trunk/src/includes/extend/buddypress/groups.php

    r5829 r5868  
    295295                        bbp_dropdown( array(
    296296                            'select_id' => 'bbp_group_forum_id',
    297                             'show_none' => __( '(No Forum)', 'bbpress' ),
     297                            'show_none' => __( '&mdash; No forum &mdash;', 'bbpress' ),
    298298                            'selected'  => $forum_id
    299299                        ) );
  • trunk/src/templates/default/bbpress/form-forum.php

    r5838 r5868  
    139139                            bbp_dropdown( array(
    140140                                'select_id' => 'bbp_forum_parent_id',
    141                                 'show_none' => esc_html__( '(No Parent)', 'bbpress' ),
     141                                'show_none' => esc_html__( '&mdash; No parent &mdash;', 'bbpress' ),
    142142                                'selected'  => bbp_get_form_forum_parent(),
    143143                                'exclude'   => bbp_get_forum_id()
  • trunk/src/templates/default/bbpress/form-topic.php

    r5829 r5868  
    120120                            <?php
    121121                                bbp_dropdown( array(
    122                                     'show_none' => esc_html__( '(No Forum)', 'bbpress' ),
     122                                    'show_none' => esc_html__( '&mdash; No forum &mdash;', 'bbpress' ),
    123123                                    'selected'  => bbp_get_form_topic_forum()
    124124                                ) );
Note: See TracChangeset for help on using the changeset viewer.