Changeset 5858 for trunk/src/includes/forums/functions.php

Timestamp:

07/16/2015 04:15:12 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Queries: Clean up post status concatenation in 2 queries.

This changeset moves array of "hidden" type post-statuses into their own variable to better match existing usages.

Fixes #2826.

File:

• trunk/src/includes/forums/functions.php (modified) (1 diff)

trunk/src/includes/forums/functions.php

@@ -1586 +1586 @@
         // Get topics of forum
         if ( empty( $topic_count ) ) {
+            $statuses    = array( bbp_get_trash_status_id(), bbp_get_spam_status_id(), bbp_get_pending_status_id() );
+            $post_status = "'" . implode( "','", $statuses ) . "'";
             $bbp_db      = bbp_db();
-            $post_status = "'" . implode( "','", array( bbp_get_trash_status_id(), bbp_get_spam_status_id(), bbp_get_pending_status_id() ) ) . "'";
             $topic_count = $bbp_db->get_var( $bbp_db->prepare( "SELECT COUNT(ID) FROM {$bbp_db->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s';", $forum_id, bbp_get_topic_post_type() ) );
         }