Changeset 5856

Timestamp:

07/16/2015 03:26:57 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Forums: Introduce bbp_update_forum_visibility action in bbp_save_forum_extras()

This changeset provides custom visibilites with an execution point to perform their own actions.

Fixes #2740.

File:

• trunk/src/includes/forums/functions.php (modified) (5 diffs)

trunk/src/includes/forums/functions.php

@@ -670 +670 @@
     }
 
-    /** Forum Status ******************************************************/
+    /** Forum Status **********************************************************/
 
     if ( ! empty( $_POST['bbp_forum_status'] ) && in_array( $_POST['bbp_forum_status'], array( 'open', 'closed' ) ) ) {
@@ -682 +682 @@
     }
 
-    /** Forum Type ********************************************************/
+    /** Forum Type ************************************************************/
 
     if ( ! empty( $_POST['bbp_forum_type'] ) && in_array( $_POST['bbp_forum_type'], array( 'forum', 'category' ) ) ) {
@@ -694 +694 @@
     }
 
-    /** Forum Visibility **************************************************/
-
-    if ( ! empty( $_POST['bbp_forum_visibility'] ) && in_array( $_POST['bbp_forum_visibility'], array( bbp_get_public_status_id(), bbp_get_private_status_id(), bbp_get_hidden_status_id() ) ) ) {
+    /** Forum Visibility ******************************************************/
+
+    if ( ! empty( $_POST['bbp_forum_visibility'] ) && in_array( $_POST['bbp_forum_visibility'], array_keys( bbp_get_forum_visibilities() ) ) ) {
 
         // Get forums current visibility
-        $visibility = bbp_get_forum_visibility( $forum_id );
+        $old_visibility = bbp_get_forum_visibility( $forum_id );
+
+        // Sanitize the new visibility
+        $new_visibility = sanitize_key( $_POST['bbp_forum_visibility'] );
 
         // What is the new forum visibility setting?
-        switch ( $_POST['bbp_forum_visibility'] ) {
+        switch ( $new_visibility ) {
 
             // Hidden
             case bbp_get_hidden_status_id()  :
-                bbp_hide_forum( $forum_id, $visibility );
+                bbp_hide_forum( $forum_id, $old_visibility );
                 break;
 
             // Private
             case bbp_get_private_status_id() :
-                bbp_privatize_forum( $forum_id, $visibility );
+                bbp_privatize_forum( $forum_id, $old_visibility );
                 break;
 
             // Publish (default)
             case bbp_get_public_status_id()  :
-            default        :
-                bbp_publicize_forum( $forum_id, $visibility );
+            default :
+                bbp_publicize_forum( $forum_id, $old_visibility );
                 break;
         }
-    }
-}
-
-/** Forum Actions *************************************************************/
+
+        /**
+         * Allow custom forum visibility save actions
+         *
+         * @since bbPress (r5855)
+         *
+         * @param int    $forum_id       The forum ID
+         * @param string $old_visibility The current forum visibility
+         * @param string $new_visibility The new forum visibility
+         */
+        do_action( 'bbp_update_forum_visibility', $forum_id, $old_visibility, $new_visibility );
+    }
+}
+
+/** Forum Open/Close **********************************************************/
 
 /**
@@ -774 +788 @@
 }
 
+/** Forum Type ****************************************************************/
+
 /**
  * Make the forum a category
@@ -817 +833 @@
     return $forum_id;
 }
+
+/** Forum Visibility **********************************************************/
 
 /**