Changeset 5842

Timestamp:

07/15/2015 09:12:51 PM (10 years ago)

Author:

johnjamesjacoby

Message:

IDs: Some reply functions still default to their topics if no replies are present. This functionality has slowly been removed over time and built into respective functions. In this changeset, we remove those leftover assignments and update a few phpdoc descriptions as needed.

Hat-tip netweb. See #2806.

Location:

trunk/src/includes

Files:

• admin/replies.php (modified) (1 diff)
• extend/akismet.php (modified) (1 diff)
• forums/template.php (modified) (1 diff)
• topics/template.php (modified) (2 diffs)

trunk/src/includes/admin/replies.php

@@ -761 +761 @@
      * @uses bbp_get_reply_post_type() To get the reply post type
      * @uses bbp_reply_content() To output reply content
-     * @uses bbp_get_reply_permalink() To get the reply link
+     * @uses bbp_get_reply_url() To get the reply link
      * @uses bbp_get_reply_title() To get the reply title
      * @uses current_user_can() To check if the current user can edit or

trunk/src/includes/extend/akismet.php

@@ -147 +147 @@
 
         if ( ! empty( $post_data['post_parent'] ) ) {
+
             // Use post parent for permalink
             $post_permalink = get_permalink( $post_data['post_parent'] );

trunk/src/includes/forums/template.php

@@ -1090 +1090 @@
         $reply_id = get_post_meta( $forum_id, '_bbp_last_reply_id', true );
 
-        if ( empty( $reply_id ) ) {
-            $reply_id = bbp_get_forum_last_topic_id( $forum_id );
-        }
-
         return (int) apply_filters( 'bbp_get_forum_last_reply_id', (int) $reply_id, $forum_id );
     }

trunk/src/includes/topics/template.php

@@ -2011 +2011 @@
         $reply_id = get_post_meta( $topic_id, '_bbp_last_reply_id', true );
 
-        if ( empty( $reply_id ) ) {
-            $reply_id = $topic_id;
-        }
-
         return (int) apply_filters( 'bbp_get_topic_last_reply_id', (int) $reply_id, $topic_id );
     }
@@ -2098 +2094 @@
      * @uses bbp_get_topic_last_reply_id() To get the topic last reply id
      * @uses bbp_get_reply_url() To get the reply url
-     * @uses bbp_get_reply_permalink() To get the reply permalink
+     * @uses bbp_get_topic_permalink() To get the topic permalink
      * @uses apply_filters() Calls 'bbp_get_topic_last_topic_url' with
      *                        the reply url and topic id